Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soef error instead of exception when trying to register an address that is already registered #2648

Open
5A11 opened this issue Oct 7, 2021 · 0 comments

Comments

@5A11
Copy link
Member

5A11 commented Oct 7, 2021

Is your feature request related to a problem? Please describe.

The soef connection currently raises an exception if it receives a message trying to register an address that is already registered: https://github.com/fetchai/agents-aea/blob/main/packages/fetchai/connections/soef/connection.py#L524-L528.

Describe the solution you'd like

It is probably better handled by responding with an error message indicating that the address is already registered so an agent can handle this case

Describe alternatives you've considered

Keep it as an exception.

@5A11 5A11 changed the title soef soef error instead of exception when trying to register an address that is already registered Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant