Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate MeshFromRefinements #855

Closed
RemDelaporteMathurin opened this issue Aug 1, 2024 · 0 comments · Fixed by #893
Closed

Deprecate MeshFromRefinements #855

RemDelaporteMathurin opened this issue Aug 1, 2024 · 0 comments · Fixed by #893
Labels
good first issue Good for newcomers
Milestone

Comments

@RemDelaporteMathurin
Copy link
Collaborator

RemDelaporteMathurin commented Aug 1, 2024

I think it is time to deprecate MeshFromRefinements.

https://github.com/festim-dev/FESTIM/blob/main/festim/meshing/mesh_from_refinements.py

It is a very old class that have been replaced by MeshFromVertices in pretty much all demos and examples.

We should:

  • Remove MeshFromRefinements
  • Remove the tests
  • Remove the documentation

I don't think we need to worry about backwards compatibility. I don't know a single user who uses this class.

If for some reason someone really needs it, please let us know here so that we can assist you.

@RemDelaporteMathurin RemDelaporteMathurin added the good first issue Good for newcomers label Aug 1, 2024
@RemDelaporteMathurin RemDelaporteMathurin added this to the UKAEA workshop milestone Aug 1, 2024
@RemDelaporteMathurin RemDelaporteMathurin removed this from the UKAEA workshop milestone Oct 8, 2024
@RemDelaporteMathurin RemDelaporteMathurin added this to the 1.4 milestone Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant