Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: "Play once" for delayed jobs #363

Open
rtroncoso opened this issue Jan 10, 2022 · 4 comments
Open

[Feature Request]: "Play once" for delayed jobs #363

rtroncoso opened this issue Jan 10, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@rtroncoso
Copy link

Wanted to know if it's possible to add a "Play once" (name suggestions open) button for delayed jobs, similar to the "Promote" (#136) feature, but with the difference that it should not interfere with the already delayed job (i.e. a cron execution at a certain time).

Right now when you try to promote a delayed job with a repeat.cron set in options the job will execute inmediately, but a new job is added with the same delay as before. Therefore, if I have a job that runs every week at a given time and promote it, the execution of the next job will be one week after the original execution time.

@felixmosh
Copy link
Owner

felixmosh commented Jan 11, 2022

An interesting idea, I think that it is possible, by cloning the given job, and adding it without any delay options.

I will review a possible implementation, the scary thing is to mess with user's options.

Maybe, it's time to implement a "Add new job" from the UI (a requested feature), which will allow to use other job data.
This will solve your issue, and won't make the code change user's data.

WDYT?

@rtroncoso
Copy link
Author

rtroncoso commented Jan 11, 2022

@felixmosh yup, definitely think that would be great and could fit all use cases, also leaving room for more advanced ones (maybe override job data, custom delay, etc)!

@felixmosh felixmosh added the enhancement New feature or request label Jan 19, 2022
@DmitryRibalka
Copy link

@felixmosh Very good feature. Hitting the promote button ruins next scheduled run of the job. Have to wait next interval. Plz, consider implement this enhancement.

@felixmosh
Copy link
Owner

Now that v5.18.0 added Add job feature, this feature can be implemented easly by implementing "duplicate" job, which opens a Add Job modal with predefined fields, you can modify it as you wish, and run it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants