Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Remove reflection stuff #5

Open
4 tasks
felipebaltazar opened this issue Aug 20, 2021 · 0 comments
Open
4 tasks

[Improvement] Remove reflection stuff #5

felipebaltazar opened this issue Aug 20, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@felipebaltazar
Copy link
Owner

felipebaltazar commented Aug 20, 2021 •
edited
Loading

Description

We should remove reflection from BaseFeature using source generators to build the default values.
This change will set FeatureFlag.Management.Firebase as required dependency.. so we need to change this package name to FeatureFlag.Management.Analyzer

Tasks

  • Remove BaseFeature processing for default value
  • Update BaseFeature to be partial class
  • Update generator to build default values as constants
  • Fix workflows
@felipebaltazar felipebaltazar added the enhancement New feature or request label Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@felipebaltazar