Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

not use sub process to fetch mmdb #11

Open
rogeryk opened this issue Apr 14, 2021 · 0 comments
Open

not use sub process to fetch mmdb #11

rogeryk opened this issue Apr 14, 2021 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@rogeryk
Copy link

rogeryk commented Apr 14, 2021

I find some warning log when i run systemctl --user start clash

clash.service: Found left-over process 2868 (python3) in control group while starting unit. Ignoring.
This usually indicates unclean termination of a previous run, or service implementation deficiencies

The clash server config ExecStartPre=/usr/bin/clashup --pre
and I find clashup script which use daemon to fetch mmdb. It will create a sub process.

if self.config.get('mmdb_version_url') and self.config.get('mmdb_file_url'):
    with daemon.DaemonContext():
        self.update_mmdb()

When I removed the mmdb configuration, it was just fine. And I find
https://www.freedesktop.org/software/systemd/man/systemd.service.html

Note that ExecStartPre= may not be used to start long-running processes. All processes forked off by processes invoked via ExecStartPre= will be killed before the next service process is run.

Maybe it should be deleted here.

@felinae98 felinae98 added the help wanted Extra attention is needed label Nov 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants