fix: On windows path gets resolved with error because all / get replaced with \ even in closing tokens #676

jtdLab · 2022-12-23T04:14:09Z

Description

/ that are part of the closing tokens aka {{/foo}} get converted to a \ on windows when used in path.

Steps To Reproduce

Brick with __brick__/{{#foo}}boom/baam/booz{{/foo}}/README.md
Generate README.md

Expected Behavior
README.md should be generated at location boom\baam\booz\ if foo is true

But instead the /from {{/foo}} gets convertet to a \ and leads to an error
OS Error: The system cannot find the path specified

The text was updated successfully, but these errors were encountered:

felangel · 2022-12-23T04:58:51Z

Hi @jtdLab 👋
Thanks for opening an issue!

What is the value of the foo variable in this case? Can you please provide a link to a minimal reproduction sample? Thanks!

jtdLab · 2022-12-23T22:17:06Z

Checkout the repo:

https://github.com/jtdLab/mason_windows_failure

Hint: the repo contains a github action run which illustrates the problem (mason generation fails on windows and completes on linux.)

Hope that helps

jtdLab · 2022-12-29T01:19:00Z

@felangel

stcojo · 2023-01-04T06:44:47Z

@felangel facing the same problem on Windows 10.

FileSystemException: Directory listing failed, path = 'C:/Users/Stefan/AppData/Local/Mason/Cache/git/mason_bricks_aHR0cHM6Ly9naXRodWIuY29tL2thY2l1bGEvbWFzb25fYnJpY2tz_b7a40356a469ad04579114864c70650cd4f12a50/app\__brick__\{{ projectName.lowerCase() }}\lib\features\common\data\local\{{#useHive}}locvbWFzb25fYnJpY2tz_b7a40356a469ad04579114864c70650cd4f12a50/app\__brical_store.dart{{\*' (OS Error: The system cannot find the path specified. ied. , errno = 3)

felangel · 2023-01-04T16:05:38Z

@jtdLab @stcojo sorry for the delay (I was not able to get to this during the holiday break). I'm planning to take a closer look later today and hopefully get a fix for this very soon. Sorry for the inconvenience!

felangel · 2023-01-16T21:14:33Z

@jtdLab can you re-test using the master branch of mason and regenerate the bundle?

jtdLab · 2023-02-15T11:50:29Z

@felangel im sry but looks like the error seems to be still around after regenerating the bundle.

jtdLab · 2023-02-15T14:59:13Z

@felangel I think the error is caused by the Maximum Path Length Limitation in the Windows API

felangel · 2023-02-28T04:17:29Z

@jtdLab apologies for the delay. I finally tried to reproduce the issue on a windows machine and was not able to reproduce using the latest version of mason. Can you please re-test using the latest version and let me know if this is still an issue for you? Thanks!

jtdLab · 2023-02-28T12:15:05Z

@felangel i simplified the example at https://github.com/jtdLab/mason_windows_failure the action run illustrates the problem.

stcojo · 2023-03-18T11:26:31Z

@felangel Problem still persists after updating to Updated to 0.1.0-dev.50

jtdLab · 2023-03-24T18:36:35Z

@felangel any updates on this?

felangel · 2023-05-19T05:32:18Z

@jtdLab apologies for the delay! I need to get my hands on a windows machine (should hopefully be able to pick one up this weekend).

jtdLab · 2023-05-19T12:04:31Z

@felangel I think the error is caused by the Maximum Path Length Limitation in the Windows API

@felangel This might help.

predatorx7 · 2023-05-24T05:17:14Z

I'm facing a similar issue on Windows 10. I'm using mason's version 0.1.0-dev.50.

Output of `mason add generate -g`

PS > mason add generate -g
PathNotFoundException: Directory listing failed, path = 'C:\Users\BroadBand\AppData\Local\Mason\Cache\hosted\registry.brickhub.dev\generate_0.1.3\__brick__\{{#has_tests}}test\widgets\{{#is_schematic_widget}}{{name.snakeCase()}}\{{#needs_theme_for_widget}}{{name.snakeCase()}}_theme_test.dart{{\needs_theme_for_widget}}{{\*' (OS Error: The system cannot find the path specified.
, errno = 3)

Output of `flutter doctor -v`

[✓] Flutter (Channel stable, 3.10.1, on Microsoft Windows [Version 10.0.19045.2965], locale en-IN)
    • Flutter version 3.10.1 on channel stable at C:\sdks\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision d3d8effc68 (7 days ago), 2023-05-16 17:59:05 -0700
    • Engine revision b4fb11214d
    • Dart version 3.0.1
    • DevTools version 2.23.1

[✓] Windows Version (Installed version of Windows is version 10 or higher)

[!] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
    • Android SDK at C:\Users\BroadBand\AppData\Local\Android\Sdk
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/windows#android-setup for more details.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[✓] Visual Studio - develop for Windows (Visual Studio Community 2022 17.6.0)
    • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
    • Visual Studio Community 2022 version 17.6.33712.159
    • Windows 10 SDK version 10.0.22000.0

[✓] Android Studio (version 2022.2)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-b2043.56-9586694)

[✓] VS Code (version 1.78.2)
    • VS Code at C:\Users\BroadBand\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.64.0

[✓] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.19045.2965]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 113.0.5672.127
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 113.0.1774.50

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

felangel · 2023-05-24T13:47:22Z

I just got a windows machine yesterday so I will finally look at this more closely later today. Sorry for the inconvenience!

yahu1031 · 2023-06-03T19:49:06Z

@felangel Doesn't path package resolve this issue?

* initial commit * adding missing tests * docs * Update bricks/dart_frog_prod_server/hooks/pre_gen.dart * Apply suggestions from code review Co-authored-by: Scarlett Eliza <[email protected]> * fix: docs format --------- Co-authored-by: Scarlett Eliza <[email protected]>

stcojo · 2023-06-18T15:13:53Z

Any updates on this @felangel ? thanks

mrverdant13 · 2023-08-21T00:12:41Z

I was facing the same issue

The odd thing was that the paths were not congruent

After debugging the mason_cli locally, I found that the root cause is related to the cache.
In my case, this bug seemed to be triggered when I moved the brick directory to another nested location.
Since I was working on a globally added local brick, I just run mason remove -g <my_brick> and I didn't struggle with the issue again. I guess the same applies to mason cache clear.

tomarra · 2024-01-29T19:49:01Z

Alright I think we have a related ticket on very_good_flutter_plugin that can quickly reproduce the issue. For all the details take a look at VeryGoodOpenSource/very_good_flutter_plugin#144

Steps to Reproduce

dart pub global activate very_good_cli
dart pub global activate mason_cli
mason add -g very_good_flutter_plugin

Pretty quickly you get the same error message

PathNotFoundException: Directory listing failed, path = 'C:/Users/Tom Arra/AppData/Local/Mason/Cache/hosted/registry.brickhub.dev/very_good_flutter_plugin_0.6.0\__brick__\{{project_name.snakeCase()}}\{{project_name.snakeCase()}}\example\{{#android}}android{{\android}}\app\src\main\kotlin\com\example\{{project_name.snakeCase()}}\*' (OS Error: The system cannot find the path specified.

felangel · 2024-01-30T00:42:20Z

Alright I think we have a related ticket on very_good_flutter_plugin that can quickly reproduce the issue. For all the details take a look at VeryGoodOpenSource/very_good_flutter_plugin#144

Steps to Reproduce

dart pub global activate very_good_cli

dart pub global activate mason_cli

mason add -g very_good_flutter_plugin

Pretty quickly you get the same error message

PathNotFoundException: Directory listing failed, path = 'C:/Users/Tom Arra/AppData/Local/Mason/Cache/hosted/registry.brickhub.dev/very_good_flutter_plugin_0.6.0\__brick__\{{project_name.snakeCase()}}\{{project_name.snakeCase()}}\example\{{#android}}android{{\android}}\app\src\main\kotlin\com\example\{{project_name.snakeCase()}}\*' (OS Error: The system cannot find the path specified.

Awesome I’ll have a look asap, thanks!

nouman-hanif · 2024-04-19T19:29:41Z

any progress on this? I am facing this issue on Windows 11. This is keeping us from using mason to install new bricks from github

jtdLab added the bug Something isn't working label Dec 23, 2022

jtdLab changed the title ~~fix: On windows path gets resolved with error becaus all / get replaced with \ even in closing tokens~~ fix: On windows path gets resolved with error because all / get replaced with \ even in closing tokens Dec 23, 2022

felangel added question Further information is requested waiting for response Waiting for additional information labels Dec 23, 2022

felangel self-assigned this Dec 23, 2022

felangel added investigating Investigating a reported issue and removed question Further information is requested waiting for response Waiting for additional information labels Jan 4, 2023

felangel mentioned this issue Jan 7, 2023

ci(mason): run on macos, windows, and linux #693

Merged

8 tasks

jtdLab closed this as completed Jan 31, 2023

jtdLab reopened this Feb 15, 2023

jtdLab linked a pull request Feb 15, 2023 that will close this issue

fix(mason): bug where long path leads to error on windows #759

Open

7 tasks

felangel added waiting for response Waiting for additional information and removed investigating Investigating a reported issue labels Feb 28, 2023

renancaraujo mentioned this issue May 19, 2023

fix: Plugin creation throws PathNotFoundException in Windows VeryGoodOpenSource/very_good_cli#728

Open

felangel removed the waiting for response Waiting for additional information label May 24, 2023

tomarra mentioned this issue Jan 29, 2024

fix: making the plugin in Windows 11 fails with due to an unhandled exception VeryGoodOpenSource/very_good_flutter_plugin#144

Closed

felangel added the investigating Investigating a reported issue label Jan 30, 2024

alestiago added the customer:🦄 label Mar 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: On windows path gets resolved with error because all / get replaced with \ even in closing tokens #676

fix: On windows path gets resolved with error because all / get replaced with \ even in closing tokens #676

jtdLab commented Dec 23, 2022

felangel commented Dec 23, 2022

jtdLab commented Dec 23, 2022

jtdLab commented Dec 29, 2022

stcojo commented Jan 4, 2023

felangel commented Jan 4, 2023

felangel commented Jan 16, 2023

jtdLab commented Feb 15, 2023

jtdLab commented Feb 15, 2023 •

edited

Loading

felangel commented Feb 28, 2023

jtdLab commented Feb 28, 2023

stcojo commented Mar 18, 2023

jtdLab commented Mar 24, 2023

felangel commented May 19, 2023

jtdLab commented May 19, 2023

predatorx7 commented May 24, 2023

felangel commented May 24, 2023

yahu1031 commented Jun 3, 2023

stcojo commented Jun 18, 2023

mrverdant13 commented Aug 21, 2023

tomarra commented Jan 29, 2024

felangel commented Jan 30, 2024

nouman-hanif commented Apr 19, 2024

fix: On windows path gets resolved with error because all / get replaced with \ even in closing tokens #676

fix: On windows path gets resolved with error because all / get replaced with \ even in closing tokens #676

Comments

jtdLab commented Dec 23, 2022

felangel commented Dec 23, 2022

jtdLab commented Dec 23, 2022

jtdLab commented Dec 29, 2022

stcojo commented Jan 4, 2023

felangel commented Jan 4, 2023

felangel commented Jan 16, 2023

jtdLab commented Feb 15, 2023

jtdLab commented Feb 15, 2023 • edited Loading

felangel commented Feb 28, 2023

jtdLab commented Feb 28, 2023

stcojo commented Mar 18, 2023

jtdLab commented Mar 24, 2023

felangel commented May 19, 2023

jtdLab commented May 19, 2023

predatorx7 commented May 24, 2023

felangel commented May 24, 2023

yahu1031 commented Jun 3, 2023

stcojo commented Jun 18, 2023

mrverdant13 commented Aug 21, 2023

tomarra commented Jan 29, 2024

felangel commented Jan 30, 2024

nouman-hanif commented Apr 19, 2024

jtdLab commented Feb 15, 2023 •

edited

Loading