No more test_feincms3

Author: matthiask

tests/testapp/test_feincms3.py renamed to tests/testapp/test_pages.py

@@ -5,15 +5,13 @@
 from django.core.checks import Warning
 from django.core.exceptions import ValidationError
 from django.db import IntegrityError, connection, transaction
-from django.test import RequestFactory
 from django.test.utils import CaptureQueriesContext, isolate_apps, override_settings
 from django.urls import reverse
 from pytest_django.asserts import assertContains, assertRedirects
 
 from feincms3 import mixins
 from feincms3.pages import AbstractPage
-from feincms3.shortcuts import render_list
-from testapp.models import Article, Page
+from testapp.models import Page
 
 
 def zero_management_form_data(prefix):
@@ -698,23 +696,6 @@ def test_get_absolute_url():
     assert Page(path="/").get_absolute_url() == "/"
 
 
-@pytest.mark.django_db
-def test_render_list():
-    """render_list, automatic template selection and pagination"""
-    for i in range(7):
-        Article.objects.create(title=f"Article {i}", category="publications")
-
-    request = RequestFactory().get("/", data={"page": 2})
-    response = render_list(
-        request, list(Article.objects.all()), model=Article, paginate_by=2
-    )
-
-    assert response.template_name == "testapp/article_list.html"
-    assert len(response.context_data["object_list"]) == 2
-    assert response.context_data["object_list"].number == 2
-    assert response.context_data["object_list"].paginator.num_pages == 4
-
-
 @isolate_apps("testapp")
 def test_page_with_missing_ordering():
     """Page subclass without ordering doesn't check out"""

tests/testapp/test_utils.py

@@ -3,10 +3,13 @@
 
 import pytest
 from django.template import Context, Template
+from django.test import RequestFactory
 from django.test.utils import override_settings
 from pytest_django.asserts import assertHTMLEqual
 
+from feincms3.shortcuts import render_list
 from feincms3.utils import is_first_party_link, upload_to
+from testapp.models import Article
 
 
 @pytest.mark.parametrize(
@@ -81,3 +84,20 @@ def test_upload_to():
     assert upload_to(instance, filename) == "/".join(
         ["image", ordinal[1:3], ordinal[3:6], filename]
     )
+
+
+@pytest.mark.django_db
+def test_render_list():
+    """render_list, automatic template selection and pagination"""
+    for i in range(7):
+        Article.objects.create(title=f"Article {i}", category="publications")
+
+    request = RequestFactory().get("/", data={"page": 2})
+    response = render_list(
+        request, list(Article.objects.all()), model=Article, paginate_by=2
+    )
+
+    assert response.template_name == "testapp/article_list.html"
+    assert len(response.context_data["object_list"]) == 2
+    assert response.context_data["object_list"].number == 2
+    assert response.context_data["object_list"].paginator.num_pages == 4