Skip to content

Commit ecebc25

Browse files
committed
Fixes #207 Inform user, why test is cancelled or skipped.
Signed-off-by: Petr "Stone" Hracek <[email protected]>
1 parent 0d33434 commit ecebc25

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

moduleframework/mtf_scheduler.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -258,11 +258,11 @@ def show_error(self):
258258
# errors follow after 'normal' output with no delimiter, then with -------
259259
delimiter = ""
260260
for testcase in data['tests']:
261-
if testcase.get('status') in ['ERROR', 'FAIL']:
261+
if testcase.get('status') in ['ERROR', 'FAIL', 'SKIP', 'CANCEL']:
262262
common.print_info(delimiter)
263263
common.print_info("TEST: {0}".format(testcase.get('id')))
264-
common.print_info("ERROR: {0}".format(
265-
testcase.get('fail_reason')))
264+
common.print_info("{0}: {1}".format(testcase.get('status'),
265+
testcase.get('fail_reason')))
266266
common.print_info(" {0}".format(
267267
testcase.get('logfile')))
268268
delimiter = "-------------------------"

moduleframework/tests/generic/modulelint.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ class ModuleLintSigning(module_framework.AvocadoTest):
3434
def setUp(self):
3535
# it is not intended just for docker, but just docker packages are
3636
# actually properly signed
37-
if self.moduleType != "docker":
38-
self.skip("Docker specific test")
37+
if self.moduleType != "docker" and self.moduleType != "openshift":
38+
self.cancel("Docker or OpenShift specific test")
3939
super(self.__class__, self).setUp()
4040

4141
def test(self):

moduleframework/tests/static/dockerfile_lint.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ def setUp(self):
1919
# actually properly signed
2020
self.dp = dockerlinter.DockerfileLinter()
2121
if self.dp.dockerfile is None:
22-
self.skip("Dockerfile was not found")
22+
self.cancel("Dockerfile was not found")
2323

2424
def test_from_is_first_directive(self):
2525
self.assertTrue(self.dp.check_from_is_first(), msg="FROM instruction is not first.")

moduleframework/tests/static/helpmd_lint.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ def setUp(self):
4242
self.helpmd = helpfile_linter.HelpMDLinter()
4343
self.dp = dockerlinter.DockerfileLinter()
4444
if self.helpmd.help_md is None or self.dp.dockerfile is None:
45-
self.skip("Help file or Dockerfile was not found")
45+
self.cancel("Help file or Dockerfile was not found")
4646

4747
def tearDown(self, *args, **kwargs):
4848
pass

0 commit comments

Comments
 (0)