-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unified Toasting Error / Notification scheme across gateway and guardian #496
Comments
Hi @Kodylow, I may have encountered a little bug when using SharedChakraProvider. To replicate this:
I hope this information is useful, also if there are any suggestions I will be grateful. |
Can you post code for where that's happening? not sure what you mean here |
Hi @Kodylow, After some testing, I found that SharedChakraProvider wasn’t configuring ToastProvider, which is essential for toasts. I resolved this by wrapping SharedChakraProvider inside ChakraProvider in the main structure, ensuring ToastProvider is accessible across components using useToast. If needed, I could add ToastProvider directly within SharedChakraProvider for a more modular setup. I've attached a quick video showing the toasts in action, and you can check the latest commit branch "notification-toast" for details. Thanks in advance for any feedback! |
ChakraProvide.mp4 |
oh awesome! yeah if you could stick it in the shared one or refactor it to just have it be a clean add then that'll be great, would love to get this landed so we can redo a bunch of these errors to make them nicer |
Great. WIP👌 |
Currently we don't give errors or notifications in a unified way, we should use chakra's toasting system for it. I want the toasts to come up in the top right and we should do that for everything where there's an error at first but then eventually with transaction monitoring and such add those incoming and outgoing updates to it https://v2.chakra-ui.com/docs/components/toast
The text was updated successfully, but these errors were encountered: