Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content of link tag is not embded it self to head #314

Open
bbprojectnet opened this issue Sep 18, 2023 · 2 comments
Open

Content of link tag is not embded it self to head #314

bbprojectnet opened this issue Sep 18, 2023 · 2 comments

Comments

@bbprojectnet
Copy link

According to README:

obraz

it's not true.

I have some @media in my mail css, which is skipped due this bug.

@DannyvdSluijs
Copy link
Collaborator

DannyvdSluijs commented Sep 19, 2023

Thanks for bringing this to the attention. You're correct when using an inline style element it is kept (at least when using Laravel 10) but when using the link element the style is applied to the target and not being inlined in the HTML.

Would the expected result be that the link element is resolved to a style element as well on top of the applied styles to the target element?

I have some @media in my mail css, which is skipped due this bug.

Can you provide an example?

@bbprojectnet
Copy link
Author

bbprojectnet commented Sep 19, 2023

Would the expected result be that the link element is resolved to a style element as well on top of the applied styles to the target element?

I think yes, like in README example.

Can you provide an example?

It doesn't really matter, as you mentioned, I think all content should be unpacked into a <style> tag.

But now whatever is in the external sheet (even a simple selector) is not included as a <style> tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants