Skip to content

Commit bd267b7

Browse files
committed
Fix events firing in wrong order
1 parent 7aff89f commit bd267b7

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

lib/Dom.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,8 +146,8 @@ export default class Dom {
146146
public click (element: HTMLElement): void {
147147
this.triggerEvent(element, 'mousedown')
148148
this.triggerEvent(element, 'mouseup')
149-
element.click()
150149
element.focus()
150+
element.click()
151151
}
152152

153153
public querySelectorAll (element: HTMLElement, selector: string, {visibleOnly = true} = {}): HTMLElement[] {

test/domSpec.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ describe('dom', () => {
158158
const events = []
159159
const checkbox = assembly.insertHtml('<input type="checkbox"/>')
160160

161-
;['mousedown', 'mouseup', 'click'].forEach(type => {
161+
;['mousedown', 'mouseup', 'click', 'focusin'].forEach(type => {
162162
checkbox.addEventListener(type, () => events.push(type))
163163
})
164164

@@ -167,7 +167,8 @@ describe('dom', () => {
167167
expect(events).to.eql([
168168
'mousedown',
169169
'mouseup',
170-
'click'
170+
'focusin',
171+
'click',
171172
])
172173

173174
expect(checkbox.checked).to.equal(true)

0 commit comments

Comments
 (0)