Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$sort from querySyntax function in @feathersjs/typebox does not consider the extensions param, so can't sort on extensions #3526

Open
2 tasks done
eXigentCoder opened this issue Aug 24, 2024 · 0 comments

Comments

@eXigentCoder
Copy link
Contributor

Steps to reproduce

(First please check that this issue is not already solved as described
here
- if it is a general question or suggestion please start a Discussion)

  • Tell us what broke. The more detailed the better.
    I tried to add a nested sort field to the extensions for query synatx and it wouldn't work, I dug into the source code and saw that extensions are not considered, I'm not sure if this is expected behaviour or not?
    image

  • If you can, please create a simple example that reproduces the issue and link to a gist, jrepo, etc. This makes it much easier for us to debug and issues that have a reproducible example will get higher priority.

I managed to solve it for my case by passing in an intersect type as the main argument:
image

Expected behavior

Tell us what should happen

Ideally, it would be great if the properties passed in as extensions could be used on the $sort as well as the $select

Actual behavior

These properties are currently ignored
Tell us what happens instead

System configuration

Tell us about the applicable parts of your setup.

Module versions (especially the part that's not working):
"@feathersjs/typebox": "^5.0.29"

NodeJS version:
v20.14.0

Operating System:
MacOS

Browser Version:
N/A

React Native Version:
N/A

Module Loader:
npm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant