Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolver Performance #3492

Open
DaddyWarbucks opened this issue May 30, 2024 · 0 comments
Open

Resolver Performance #3492

DaddyWarbucks opened this issue May 30, 2024 · 0 comments

Comments

@DaddyWarbucks
Copy link
Member

DaddyWarbucks commented May 30, 2024

I was clicking around the repo today and noticed this issue: #3487. It reminded me that awhile back I completed an issue for yup.js that I believe resolvers could also benefit from.

See: jquense/yup#2052

The problem is that the resolvers treat ALL resolver functions as async and pushes/pops them onto the event loop. This means it schedules potentially sync work on the event loop. This can be solved by creating a more callback oriented flow that allows sync functions and async functions to be scheduled differently.

I don't think the performance benefits will be as great here as they were in yup.js. Yup generally has more "resolvers" and are more regularly sync. Feathers resolvers generally have fewer "resolvers" and are more commonly async. But, for large datasets I bet there would be a considerable performance gain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant