Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hooks should run on non-enabled methods #3457

Open
AshotN opened this issue Apr 10, 2024 · 0 comments
Open

Hooks should run on non-enabled methods #3457

AshotN opened this issue Apr 10, 2024 · 0 comments

Comments

@AshotN
Copy link
Contributor

AshotN commented Apr 10, 2024

Steps to reproduce

Discord discussion

https://codesandbox.io/p/devbox/feathers-custom-service-hooks-8m28r3?file=%2Fsrc%2Fapp.ts%3A27%2C22

export const customMethods = ['enabledMethod'] as const
...
//BEFORE ALL is called with this
app.service('custom').enabledMethod()
//But not this
app.service('custom').notEnabledMethod()

Expected behavior

Ideally hooks should run on all methods

Actual behavior

Hooks are only ran on enabled methods

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant