Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add class="feather" attribute to SVG elements #28

Open
aecio opened this issue Nov 19, 2018 · 1 comment · May be fixed by #65
Open

Add class="feather" attribute to SVG elements #28

aecio opened this issue Nov 19, 2018 · 1 comment · May be fixed by #65

Comments

@aecio
Copy link

aecio commented Nov 19, 2018

Adding the class "feather" to SVG elements would make it easier to apply CSS styles to icons.

Following is an example an SVG element that include a CSS class from https://feathericons.com:

<svg class="feather feather-activity sc-dnqmqq jxshSx" xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round" aria-hidden="true" data-reactid="36"><polyline points="22 12 18 12 15 21 9 3 6 12 2 12"></polyline></svg>
@aelfric aelfric linked a pull request Jul 3, 2020 that will close this issue
Open
@CorradoSurmanowicz
Copy link

Please merge the pull request. This is critical for proper use IMHO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add feather and feather-icon-name classes to icons. aelfric/react-feather
2 participants
@aecio @CorradoSurmanowicz