Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update twitter's icon #109

Open
akshay-99h opened this issue Aug 22, 2023 · 4 comments
Open

Update twitter's icon #109

akshay-99h opened this issue Aug 22, 2023 · 4 comments

Comments

@akshay-99h
Copy link

I was working on a project that uses react-feather. It still shows the bird logo. Now that the logo of twitter has changed to "X", I think we can update it to X here as well.

@milinddhamu
Copy link

src/icons/twitter.js , file directory for reference

@imMatheus
Copy link

I don't think it should be changed, the thing is that the "Twitter" logo is still the bird, the platform changed its name to "X" so if you want the new icon it should not be that the Twitter component changes as you very well might want the bird logo. But instead, a new icon should be added for the X logo. The question is what to name it, X is already taken, so if it were to be added maybe something like or something like that.

@milinddhamu
Copy link

i updated path to new logo in main file i mentioned above , they are not reviewing it. I opened a PR already.

@imMatheus
Copy link

There is a Issue for it already on the main feather repo. I would guess that they are going to add it once it has been added to the main Feather repo first feathericons/feather#1207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants