Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Change color of character when --use-icons used #201

Open
psynyde opened this issue Sep 24, 2024 · 3 comments
Open

Feature Request: Change color of character when --use-icons used #201

psynyde opened this issue Sep 24, 2024 · 3 comments

Comments

@psynyde
Copy link

psynyde commented Sep 24, 2024

as the title suggests is there any possibility to change font color with icons as they're tough to see when using dark theme for example.
image

@fdw
Copy link
Owner

fdw commented Sep 24, 2024

Have you tried a different theme or setting it the font color explicitly?

@psynyde
Copy link
Author

psynyde commented Sep 26, 2024

Have you tried a different theme or setting it the font color explicitly?

1st of all, Sorry for a quite late reply.

image

this is the rasi code i'm using to replicate the image above.

configuration {
     show-icons: true;
}
 textbox {
     vertical-align: 0.5;
     horizontal-align: 0.5;
}
 listview {
     columns: 7;
     lines: 9;
     cycle: false;
     dynamic: false;
     layout: vertical;
     flow: horizontal;
     reverse: false;
     fixed-height: true;
     fixed-columns: true;
}
 element {
     orientation: vertical;
     padding: 3px;
     text-color: #f0f0f0;
}
 element selected.normal {
     background-color: #202020;
     border-radius: 5px;
}
 element-icon {
     background-color: transparent;
     text-color: #f0f0f0;
     size: 24px;
     vertical-align: 0.5;
     horizontal-align: 0.5;
}
 element-text {
     enabled: false;
     text-color: #f0f0f0;
}

as you can see i've used text-color on every element related classes but still the font color is black.

my assumtion is you need to add text-color properties in this span tag but idk if it's possible as rofi doesn't follow usual css/html rules afaik

@fdw
Copy link
Owner

fdw commented Oct 3, 2024

I see, thanks. I could probably add something to the span tag, but I'm very hesitant: It must be configurable, but it shouldn't be a parameter to rofimoji.

I think the best solution would be for rofi to support the icon color in themes. And there is apparently already an issue for it: davatorium/rofi#2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants