New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ListPool.Sort #74

Open

mastef opened this issue May 31, 2024 · 0 comments · May be fixed by #75

mastef commented May 31, 2024 •

edited

Loading

Very cool project, we like it a lot.

Only thing that we're kind of missing are the sort methods

        public void Sort(Comparison<T> comparison);
        public void Sort(int index, int count, IComparer<T> comparer);
        public void Sort();
        public void Sort(IComparer<T> comparer);

I think it would be as simple as

	public void Sort() => Sort(0, Count, null);
	public void Sort(IComparer<T> comparer) => Sort(0, Count, comparer);
	public void Sort(int index, int count, IComparer<T> comparer) => Array.Sort<T>(_items, index, count, comparer);
	public void Sort(Comparison<T> comparison) => Array.Sort<T>(_items, 0, Count, Comparer<T>.Create(comparison));

mastef linked a pull request

that will close this issue

Adds Sort and Reverse methods to ListPool #75

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment