Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate "Vergleich mit anderen Editionen" #553

Closed
Tracked by #505
gerritbruening opened this issue Dec 6, 2018 · 8 comments
Closed
Tracked by #505

Integrate "Vergleich mit anderen Editionen" #553

gerritbruening opened this issue Dec 6, 2018 · 8 comments
Assignees
@thvitt
Labels
c:about s:help-wanted
Milestone
1.1

Comments

@gerritbruening
Copy link
Contributor

part of #505
@gerritbruening gerritbruening added this to the 1.0.1 milestone Dec 6, 2018
@gerritbruening gerritbruening self-assigned this Dec 6, 2018
@gerritbruening gerritbruening mentioned this issue Dec 7, 2018
Open
13 tasks
@gerritbruening
Copy link
Contributor Author

I think I have provided all the links I could. Still, the apparatus-like content does not yet look apparatus-like (no grey etc.). @thvitt, can you give me any guidance how to style this stuff?

@thvitt
Copy link
Member

thvitt commented Dec 7, 2018

probably also requires css modifications on my side …

thvitt added a commit that referenced this issue Dec 7, 2018
@thvitt
Style snippets for app styling.
38e0c4d 
Cf. #553
thvitt added a commit that referenced this issue Dec 7, 2018
@thvitt
Add app entries where automatically possible
d8a47dd 
Cf. #553
@thvitt thvitt assigned gerritbruening and unassigned thvitt Dec 7, 2018
@thvitt
Copy link
Member

thvitt commented Dec 7, 2018

argl, jetzt hab ich des falsche issue vor augen. habe grade (a) das css ergänzt und (b) für #552 committet. Schau nach dem Durchlauf mal, was noch fehlt.

@gerritbruening
Copy link
Contributor Author

Danke!
grafik

Gut wäre jetzt noch

  • Klammer grau
  • em / span ... italics wie note-Text im Apparat (grau; kleiner? Die Versnummern sind kleiner; oder die Versnummern hier nicht kleiner?)

thvitt added a commit that referenced this issue Dec 10, 2018
@thvitt
Adjustments in Vergleich mit anderen Editionen
82c597f 
Cf. #553
@thvitt
Copy link
Member

thvitt commented Dec 10, 2018

Ein paar automatisierbare Punkte habe ich nachgetragen, bitte korrigieren und ggf. manuell ergänzen

  • Apparateintrag grundsätzlich: <· class="type-textcrit">…</·> (z.B. <p>)
  • Lemmaklammern etc.: <span class="generated-text">]</span>
  • grau/kursiv, d.h. <note> im Apparat: <span class="note">

@thvitt thvitt assigned gerritbruening and unassigned thvitt Dec 10, 2018
gerritbruening added a commit that referenced this issue Dec 10, 2018
@gerritbruening
Tweak intro_text (mainly grey |)
0bc0708 
see #553
gerritbruening added a commit that referenced this issue Dec 10, 2018
@gerritbruening
Tweak intro_text
db3d797 
see #553
gerritbruening added a commit that referenced this issue Dec 10, 2018
@gerritbruening
Handle lemma ] in 9845 f.
61ec0f9 
see #553
gerritbruening added a commit that referenced this issue Dec 10, 2018
@gerritbruening
Remove idno in edition comparison for 9845 f.
49715c6 
see #553
gerritbruening added a commit that referenced this issue Dec 10, 2018
@gerritbruening
Replace ^
6c545e3 
see #553
gerritbruening added a commit that referenced this issue Dec 10, 2018
@gerritbruening
Give an expansion for "z. St."
a310955 
see #553
gerritbruening added a commit that referenced this issue Dec 10, 2018
@gerritbruening
Remove blanks before and after figure dash
f2e5296 
see #553
gerritbruening added a commit that referenced this issue Dec 10, 2018
@gerritbruening
<br> for edition comparison of 9041
ddef430 
see #553
@gerritbruening
Copy link
Contributor Author

Sehr gut, vielen Dank!
Ich habe jetzt alle Änderungen vorgenommen, die ich konnte. Was ich noch schön fände, wären zwei oder drei geschützte Leerzeichen vor den Lesarten, so wie das andernorts auch ist. Dort sehe ich mit strg +u jedoch mehrere spaces innerhalb und außerhalb unterschiedlicher spans. Deswegen weiß ich nicht, ob ich das so übertragen kann oder soll.

gerritbruening added a commit that referenced this issue Dec 10, 2018
@gerritbruening
Add missing span class="note"
96988ec 
see #553
gerritbruening added a commit that referenced this issue Dec 10, 2018
@gerritbruening
Make br appear as <br/> (<br></br> seems to create more space)
8703590 
see #553
@thvitt
Copy link
Member

thvitt commented Dec 10, 2018

andernorts entsteht der whitespace, indem die Lesarten jeweils mit <span class="rdg"> umschlossen sind. Eine CSS-Regel fuͤgt dann ein   (= U+2003 EM SPACE) vor jedem solchen rdg ein. Das koͤnnte man jetzt hier angleichen, oder eben manuell einen EM SPACE einfügen.

gerritbruening added a commit that referenced this issue Dec 11, 2018
@gerritbruening
Insert em space after ]
a27bf46 
see #553
gerritbruening added a commit that referenced this issue Dec 11, 2018
@gerritbruening
Insert em space
5c9c335 
see #553
@gerritbruening
Copy link
Contributor Author

gerritbruening commented Dec 11, 2018 •
edited
Loading

OK, danke, ich habe die em spaces eingefügt, jetzt sollte es passen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thvitt thvitt

Labels
c:about s:help-wanted
Projects
None yet
Milestone
1.1
Development

No branches or pull requests
2 participants
@thvitt @gerritbruening