Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support inscriptions in variant app & bargraph #643

Open
thvitt opened this issue Apr 4, 2019 · 0 comments
Open

Support inscriptions in variant app & bargraph #643

thvitt opened this issue Apr 4, 2019 · 0 comments
Assignees
@thvitt

Comments

@thvitt
Copy link
Member

thvitt commented Apr 4, 2019 •
edited
Loading

Basic support shouldn’t be too hard.

  • inscription declared as <change type="segment" xml:id="i_…">
  • in the transcript, each verse can be associated with one or more inscriptions:
    • preceding::milestone[@unit="stage"][1]/@change points to one or more inscription decls
    • descendant-or-self::*/@change as well, this will typically be an edit operation

So, for the bargraph, it should be enough to record the associated inscription(s) with each verse / subinterval and create separate bars for each inscription (for witnesses that have multiple inscriptions).

For the variant apparatus, it could be a first step to associate each line with an inscription and order it by the inscription’s order. We would have to look in how many cases a line may be associated with multiple inscriptions, though.

We should get a feeling about the quality of inscription metadata in the macrogenesis vs. the transcripts first, see faustedition/faust-macrogen#24
@thvitt thvitt self-assigned this Apr 4, 2019
thvitt added a commit that referenced this issue Apr 29, 2019
@thvitt
Note inscriptions in bargraph info (first draft).
193a3f2 
It is probably required to:
- create separate entries for lines containing multiple inscriptions
- group by inscription? Look how this is handled in the JS
- do we have witnesses with inscriptions _and_ with lines that cannot be
  associated with any inscription?
- maybe move from '#i_' to "@change pointing to <change type='segment'>"

Cf. #643
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thvitt thvitt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thvitt