Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML5 input types for value fields #14

Open
markedmondson opened this issue Jul 28, 2015 · 1 comment
Open

HTML5 input types for value fields #14

markedmondson opened this issue Jul 28, 2015 · 1 comment

Comments

@markedmondson
Copy link
Collaborator

We're looking to ditch datepicker since modern browsers implement this on the correctly typed html5 inputs.

I made a few tweaks with this in mind, sadly, the only "reliable" way to do it is to clone the value input, change the type and inject the clone, I'm wondering if anyone could see any reason why this wouldn't work?

https://github.com/Guestfolio/ransack_ui/tree/html5

(this relies on #12 being merged)

@steveyken
Copy link
Member

Thanks, I've merged PR #12 now so this work is freer to move forward. I'm in favour of what you've suggested above and can't see a better way to do it right now. Do you want to wrap up a pull request with the relevant work and we'll look to merge it in. Thanks again. Steve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants