Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2mmap benchmark is not working (missing gem) in Ruby 3.0.x #196

Open
etagwerker opened this issue Oct 16, 2021 · 0 comments
Open

e2mmap benchmark is not working (missing gem) in Ruby 3.0.x #196

etagwerker opened this issue Oct 16, 2021 · 0 comments

Comments

@etagwerker
Copy link
Member

Hi there,

At the moment this benchmark is not working:

➜  fast-ruby git:(master) ✗ ruby -v code/general/raise-vs-e2mmap.rb
ruby 3.0.2p107 (2021-07-07 revision 0db68f0233) [x86_64-darwin20]
<internal:/Users/etagwerker/.rvm/rubies/ruby-3.0.2/lib/ruby/3.0.0/rubygems/core_ext/kernel_require.rb>:85:in `require': cannot load such file -- e2mmap (LoadError)
	from <internal:/Users/etagwerker/.rvm/rubies/ruby-3.0.2/lib/ruby/3.0.0/rubygems/core_ext/kernel_require.rb>:85:in `require'
	from code/general/raise-vs-e2mmap.rb:2:in `<main>'

The solution would be to add this to the Gemfile:

gem 'e2mmap'

It seems that that benchmark might not be wanted in this project. After all, it is comparing Ruby vs. using the e2mmap gem. See: #95

I'm going to submit a PR removing that scenario, which should fix this issue. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant