refactor(persister): standardize naming conventions and add documentation #2945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion - Rename parseGroupIdFromPath to parseChatGroupIdFromPath in chat/changes.ts - Rename loadAllChatData to loadAllChatGroups in chat/load.ts - Rename createEmptyLoadedData to createEmptyLoadedChatData in chat/load.ts - Rename SessionDataLoad to LoadedSessionData in session/load.ts - Rename createEmptyResult to createEmptyLoadedSessionData in session/load.ts - Add ChatChangeResult type to chat/changes.ts for consistency with session pattern - Update AGENTS.md with persister naming conventions, startup modes, and error handling patterns Co-Authored-By: yujonglee <[email protected]>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for hyprnote canceled.
|
✅ Deploy Preview for hyprnote-storybook canceled.
|
✅ Deploy Preview for howto-fix-macos-audio-selection canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Standardizes naming conventions across TinyBase persisters for better consistency and maintainability. Also adds documentation to AGENTS.md describing the persister patterns and conventions.
Naming changes:
parseGroupIdFromPath→parseChatGroupIdFromPath(matchesparseSessionIdFromPath)loadAllChatData→loadAllChatGroups(clearer entity name)createEmptyLoadedData→createEmptyLoadedChatData(matches pattern)SessionDataLoad→LoadedSessionData(matchesLoadedChatData)createEmptyResult→createEmptyLoadedSessionData(matches pattern)Type additions:
ChatChangeResulttype to match session'sChangeResultpatternReview & Testing Checklist for Human
getChangedChatGroupIdsbehavioral change: The function now returnsChatChangeResultobject instead ofSet<string>, and addshasUnresolvedDeletionstracking when a message lacks achat_group_id. Confirm this doesn't change expected behavior in edge cases.Suggested test plan: Run the desktop app locally and verify chat persistence still works correctly (create chat groups, add messages, restart app, verify data persists).
Notes
Requested by @yujonglee
Link to Devin run: https://app.devin.ai/sessions/b0e236b3c1b24a38909129cab528c812