Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release automation per Fastify org #42

Open
Eomm opened this issue Jul 17, 2020 · 3 comments
Open

Release automation per Fastify org #42

Eomm opened this issue Jul 17, 2020 · 3 comments

Comments

@Eomm
Copy link
Member

Eomm commented Jul 17, 2020

🚀 Feature Proposal

The manual trigger on github action with easy input of parameter. This lets us build an action on GH that will run releasify and input the OTP: so we could release without the needs of a laptop.

Questions:

  • Will the OTP expires during the workflow?
  • Who is authorized to run the action?
@mcollina
Copy link
Member

Will the OTP expires during the workflow?

Unlikely, worst case you can try again. It'd be good to use an "early" OTP.. one that was newly generated.

Who is authorized to run the action?

I think anybody that has commit access to master. This would be ok for plugins, less so for fastify. However most of the tedius work is plugins.. so I think that's ok.

@Eomm
Copy link
Member Author

Eomm commented Jul 19, 2020

I was working on it but I didn't think that if I want to release with npm publish I must:

  • login to npm, running npm login
  • provide an NPM TOKEN (that doesn't require OTP) - via github secrets

So do we want to generate this dangerous token?

@mcollina
Copy link
Member

I think the token should require OTP to publish, or maybe I misunderstood the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants