-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
service.name tag of OTEL default value is not set by default to process.env.OTEL_SERVICE_NAME. #14
Closed
2 tasks done
Labels
enhancement
New feature or request
Comments
Thanks for the report! Would you like to send a PR for it? |
Yeah I can do. |
tskorupka
added a commit
to tskorupka/otel
that referenced
this issue
Feb 1, 2025
…iguration, use process.env.OTEL_SERVICE_NAME; Additionally fix some of the README.md import names, to be more meaningful.
tskorupka
added a commit
to tskorupka/otel
that referenced
this issue
Feb 1, 2025
Co-authored-by: James Sumners <[email protected]> Signed-off-by: tskorupka <[email protected]>
4 tasks
tskorupka
added a commit
to tskorupka/otel
that referenced
this issue
Feb 3, 2025
…ation tests to separate file
metcoder95
pushed a commit
that referenced
this issue
Feb 4, 2025
…on, use process.env.OTEL_SERVICE_NAME; (#17) Co-authored-by: James Sumners <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Prerequisites
Fastify version
5.2.1
Plugin version
0.2.0
Node.js version
22.12.0
Operating system
Linux
Operating system version (i.e. 20.04, 11.3, 10)
alpine 3.21.2
Description
Hey,
I think this is a bug, when I am sending my otel data via grpc to new relic endpoint, instead of seeing all traces defined under service.name equal to my OTEL_SERVICE_NAME, I see them divided into mine OTEL_SERVICE_NAME and
fastify
service.name.This ends up in having two different entities in my new relic dashboard, I can fix this by doing something like this.
I would expect this library to behave as defined in General SDK Configuration (Documentation) of OTEL.
https://opentelemetry.io/docs/languages/sdk-configuration/general/#otel_service_name
Kind Regards,
Tomasz.
Link to code that reproduces the bug
None
Expected Behavior
If I do not provide any configuration options for FastifyOtelInstrumentation, it should set
servername
default configuration option to environment variable OTEL_SERVICE_NAME, as a result it will create spans withservice.name
equal to it.The text was updated successfully, but these errors were encountered: