optimization request

Author: sirenkovladd

benchmark/benchmark.js

@@ -5,7 +5,7 @@ const http = require('http')
 const Benchmark = require('benchmark')
 const suite = new Benchmark.Suite()
 const Request = require('../lib/request')
-const parseURL = require('../lib/parseURL')
+const parseURL = require('../lib/parse-url')
 
 const mockReq = {
   url: 'http://localhost',

lib/request.js

@@ -78,6 +78,16 @@ class Request extends IncomingMessage {
     this.httpVersion = '1.1'
     this.method = options.method ? options.method.toUpperCase() : 'GET'
 
+    // Use _lightMyRequest namespace to avoid collision with Node
+    this._lightMyRequest = {
+      payload: options.payload || options.body || null,
+      isDone: false,
+      simulate: options.simulate || {},
+      authority: options.authority,
+      cookies: options.cookies,
+      hostHeader: hostHeaderFromURL(parsedURL)
+    }
+
     this.headers = {}
     this.rawHeaders = []
     const headers = options.headers || {}
@@ -98,30 +108,42 @@ class Request extends IncomingMessage {
       this.headers[fieldLowerCase] = '' + value
     }
 
+    Object.defineProperty(this, 'connection', {
+      get () {
+        warning.emit('FST_LIGHTMYREQUEST_DEP01')
+        return this.socket
+      },
+      configurable: true
+    })
+  }
+
+  getLength (payload) {
+    if (typeof payload === 'string') {
+      return Buffer.byteLength(payload)
+    }
+
+    return payload.length
+  }
+
+  parseHeader () {
     if (('user-agent' in this.headers) === false) {
       this.headers['user-agent'] = 'lightMyRequest'
     }
-    this.headers.host = this.headers.host || options.authority || hostHeaderFromURL(parsedURL)
+    this.headers.host = this.headers.host || this._lightMyRequest.authority || this._lightMyRequest.hostHeader
 
-    if (options.cookies) {
-      const { cookies } = options
+    if (this._lightMyRequest.cookies) {
+      const { cookies } = this._lightMyRequest
       const cookieValues = Object.keys(cookies).map(key => cookie.serialize(key, cookies[key]))
       if (this.headers.cookie) {
         cookieValues.unshift(this.headers.cookie)
       }
       this.headers.cookie = cookieValues.join('; ')
     }
+  }
 
-    Object.defineProperty(this, 'connection', {
-      get () {
-        warning.emit('FST_LIGHTMYREQUEST_DEP01')
-        return this.socket
-      },
-      configurable: true
-    })
-
+  parsePayload () {
     // we keep both payload and body for compatibility reasons
-    let payload = options.payload || options.body || null
+    let payload = this._lightMyRequest.payload
     const payloadResume = payload && typeof payload.resume === 'function'
 
     if (payload && typeof payload !== 'string' && !payloadResume && !Buffer.isBuffer(payload)) {
@@ -132,11 +154,7 @@ class Request extends IncomingMessage {
       }
     }
 
-    for (const header of Object.keys(this.headers)) {
-      this.rawHeaders.push(header, this.headers[header])
-    }
-
-    if (options.simulate?.end === false) {
+    if (this._lightMyRequest.simulate.end === false) {
       const prevPayload = payload
       if (payloadResume) {
         payload = new Readable({
@@ -157,23 +175,15 @@ class Request extends IncomingMessage {
       }
     }
 
-    // Use _lightMyRequest namespace to avoid collision with Node
-    this._lightMyRequest = {
-      payload,
-      isDone: false,
-      simulate: options.simulate || {}
-    }
-  }
-
-  getLength (payload) {
-    if (typeof payload === 'string') {
-      return Buffer.byteLength(payload)
-    }
-
-    return payload.length
+    this._lightMyRequest.payload = payload
   }
 
   prepare (next, onError) {
+    this.parseHeader()
+    this.parsePayload()
+    for (const header of Object.keys(this.headers)) {
+      this.rawHeaders.push(header, this.headers[header])
+    }
     let payload = this._lightMyRequest.payload
     this.complete = true
     if (payload) {