Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent License Information #99

Open
2 tasks done
vagas87 opened this issue Aug 1, 2024 · 4 comments
Open
2 tasks done

Inconsistent License Information #99

vagas87 opened this issue Aug 1, 2024 · 4 comments
Assignees

Comments

@vagas87
Copy link

vagas87 commented Aug 1, 2024

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the issue has not already been raised

Issue

License file suggests some kind of 3-clause-BSD file (because it is not 100% the original license text), but package.json is set to MIT. Please clarify the license information on this library.

@zekth
Copy link
Member

zekth commented Aug 1, 2024

@mcollina do you know how we would handle this? Original license is https://github.com/garycourt/uri-js/blob/a1acf730b4bba3f1097c9f52e7d9d3aba8cdcaae/package.json#L56

Should we update the license to specify all the commits from uri-js are BSD-2-Clause and now MIT ?

@mcollina
Copy link
Member

mcollina commented Aug 9, 2024

No. The license was never MIT. What matters is the actual license text, not the package.json.
We need to change the license field in package.json.

@mcollina
Copy link
Member

mcollina commented Aug 9, 2024

Good spot @vagas87!

@mcollina mcollina self-assigned this Aug 9, 2024
@vagas87
Copy link
Author

vagas87 commented Aug 10, 2024

Actually, kudos to my PO, who spotted this while checking SBOMs. He did not have his private GitHub credentials at hand when discovering this at work, so he asked me to open this issue for him 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants