🐛 Allow colon in zsh autocomplete values and descriptions #988
+245
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for colons in zsh completion values and descriptions, closes #162
Note that because of the
startswith
check escaping the completion options in the client side is not an option, as a value that includes a:
forincomplete
in will not pass this check.Note that we need two levels of esacping, one for zsh, and one to preserve the escape for zsh
Tested by updating the
demo.py
example in the linked issue to the following:use the provided docker image/setup to test, first that the colons show as values and descriptiosn correctly
and that an incomplete value with a colon generates options