Unpin flit-core build dependency #651
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📝 Docs preview for commit 78a0ee2 at: https://336664de.typertiangolo.pages.dev |
|
Thanks! Works for me using YoctoProject/OpenEmbedded to build python3-typer v0.7.0. |
|
Are there any updates if/when it will be merged? |
svlandeg
reviewed
Feb 29, 2024
| @@ -1,5 +1,5 @@ | |||
| [build-system] | |||
| requires = ["flit_core >=2,<3"] | |||
| requires = ["flit_core >=2"] | |||
There was a problem hiding this comment.
Suggested change
| requires = ["flit_core >=2"] | |
| requires = ["flit_core >=4"] |
As libraries can have breaking changes on major versions, it's typically good practice to have an upper pin.
That said - it looks like v3.x of flit_core works fine, so we could consider extending the range to <4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to be able to build this project in nixpkgs using the latest version of flit-core. Please let me know what you think. Thank you.