-
-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📝 Remove references to a .rst README generated by poetry new #632
📝 Remove references to a .rst README generated by poetry new #632
Conversation
📝 Docs preview for commit c97b845 at: https://64a1f6c457067b1b9d93f059--typertiangolo.netlify.app |
PR Review Reportaccording to this guide lines TL;DR: No code changed. The command Understand the problemThe docs should be updated to reflect current Poetry behavior. Check the codeReproduce the claimed solution
TestsNothing to test. DocumentationI looked at the linked docs preview and the formatting/spelling checks out. |
📝 Docs preview for commit 02ba98d at: https://1731a750.typertiangolo.pages.dev |
…github.com/jonasmmiguel/typer into doc/update-default-poetry-readme-extension
📝 Docs preview for commit b2111ff at: https://4877c586.typertiangolo.pages.dev |
📝 Docs preview for commit 7fbfad7 at: https://92ac836e.typertiangolo.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, @jonasmmiguel! I pushed a few updates directly to your branch, but overall this looks good to merge to me 😎
Great, thank you @jonasmmiguel! 🤓 Thanks @JacobKochems for the review with a comment explaining what you checked, that's super helpful! 🍰 Thanks for the review @kinuax. ☕ And thanks @svlandeg for the help as always! 😎 🎉 |
📝 Docs preview for commit bbb0d37 at: https://ef2a6b84.typertiangolo.pages.dev |
Updated the tutorial doc on packaging Typer CLI tools to reflect current Poetry behaviour.
Currently, the default extension for the README generated by
poetry new
is.md
(not.rst
) since this PR.