Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assets/dicts not committed to repo #5

Open
shirakaba opened this issue Sep 6, 2020 · 4 comments
Open

assets/dicts not committed to repo #5

shirakaba opened this issue Sep 6, 2020 · 4 comments

Comments

@shirakaba
Copy link

I imagine these files haven’t been committed due to licensing issues or file size; is that the case?
Also is there a TypeScript interface describing its contents somewhere?

@rafaelsaback
Copy link
Contributor

Indeed, I tried to run the project locally, but it's failing due to the missing dictionaries. I'll be glad to make contributions once I'm able to run it locally 🙂

Regarding the TypeScript question, the project doesn't seem to have anything TS-related, it's purely JavaScript. I confess I'm a big TS fan and I feel that as the project scales, it would be nice to add types to it (actually, the sooner the better).

@farshed
Copy link
Owner

farshed commented Sep 8, 2020

Hey @shirakaba. Yes, licensing terms on dictionary files don't allow me to share them along the source code. I'm currently rewriting the translator feature from scratch so it can support more languages and wouldn't need to be dependant on third-party dictionary data.

@rafaelsaback I don't share your sentiments about TypeScript 😅 but I'd be willing to merge any TS-related pull requests :) I just think it would be better if you hold off it for the moment till the next update is released. lt's a very big one and I'm hoping to push it by the end of the week.

@rafaelsaback
Copy link
Contributor

Hahahaha

Thanks for the heads up @farshed, I'll be looking forward to the new release 🙂

@coreyar
Copy link

coreyar commented Sep 9, 2020

Not related to the original issue but I want to offer my support via contributions. I enjoy using Typescript and find it helpful in creating robust applications. Happy to contribute to adding Typescript or another issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants