[FAI-7161] Add getWebhookEvent to faros client for use by Hermes lambda worker #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
cjwooo
approved these changes
Aug 1, 2023
chalenge
approved these changes
Aug 1, 2023
tovbinm
reviewed
Aug 1, 2023
| let event = response.data; | ||
| event = { | ||
| ...event, | ||
| createdAt: event.createdAt ? new Date(event.createdAt) : undefined, |
There was a problem hiding this comment.
@JoshSauter how come createdAt can be undefined but all other timestamp fields not?
There was a problem hiding this comment.
also, you can simply use Utils.toDate(event.createdAt) here and below
There was a problem hiding this comment.
ohh, createdAt is a timestamp from the source system which might not be necessarily set.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add getWebhookEvent to faros client for use by Hermes lambda worker when an event body is omitted from the SQS message due to being too large. getWebhookEvent needs to be exposed in Hermes API as well, that will come as part of the PR to handle large event bodies
Type of change