Telemetry off env parameter #286
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-gerber
requested review from
cjwooo,
tovbinm,
ypc-faros and
ogusak
as code owners
|
Before merging, I would like to understand why init failed for our user - it shouldn't have AFAICT: https://faroscommunity.slack.com/archives/C0335HMN2NQ/p1677263489918959 |
tovbinm
reviewed
Feb 24, 2023
| @@ -307,6 +307,7 @@ async function main(): Promise<void> { | |||
| .requiredOption('--airbyte-destination-hasura-url <string>') | |||
| .requiredOption('--hasura-admin-secret <string>') | |||
| .option('--force-setup') | |||
| .option('--telemetry-off') | |||
There was a problem hiding this comment.
Commander recommends --no-telemetry instead
There was a problem hiding this comment.
and then you can call you member in options class simply telemetry
tovbinm
approved these changes
Feb 24, 2023
|
Closing for now without merging because:
I'll keep the branch around until that work is done just in case someone else faces this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a parameter that disable telemetry completely before starting Faros CE.
Type of change
Checklist
(Delete what does not apply)