Skip to content

Conversation

@jcchavezs
Copy link

@jcchavezs jcchavezs commented Nov 19, 2025

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If this PR will release a new chart version please make sure to also uncomment the following line:

/kind chart-release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area falco-chart

/area falcosidekick-chart

/area falco-talon-chart

/area event-generator-chart

/area k8s-metacollector-chart

What this PR does / why we need it:

Adds more information on collectors.containerEngine.hook field

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Checklist

  • Chart Version bumped
  • Variables are documented in the README.md
  • CHANGELOG.md updated

@poiana
Copy link
Contributor

poiana commented Nov 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jcchavezs
Once this PR has been reviewed and has the lgtm label, please assign issif for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana requested a review from leogr November 19, 2025 14:36
Signed-off-by: José Carlos Chávez <[email protected]>
@leogr
Copy link
Member

leogr commented Nov 20, 2025

Hey @jcchavezs

Thank you for catching and fixing this! 🙏

Could you also:

  • bump the chart version
  • update the changelog
  • run make docs-falco (to update the README)
    ?

I know this is a bit cumbersome, but we need to keep things consistent (and make the CI happy 😅 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants