You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 22, 2024. It is now read-only.
If a smart contract creates or rates a note, but has a failing receive function, the finalisation of notes will always fail.
This is a cheap way for blocking our finalisation process that can be mitigated by:
not reverting on failure to reward/slash
keep track of funds that were not returned to users
allow owners of these funds to retrieve them by calling into the contract (careful re-entrancy)
We could also remove the auto-send of funds on finalisation and force people to call us to get their funds, but that is costly for users and slows down the rewards.
The text was updated successfully, but these errors were encountered:
If a smart contract creates or rates a note, but has a failing receive function, the finalisation of notes will always fail.
This is a cheap way for blocking our finalisation process that can be mitigated by:
We could also remove the auto-send of funds on finalisation and force people to call us to get their funds, but that is costly for users and slows down the rewards.
The text was updated successfully, but these errors were encountered: