Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

local Demo (created via docker compose) browser compatibility #342

Open
LongShanksBraveHeartKiller opened this issue Oct 1, 2024 · 6 comments

Comments

@LongShanksBraveHeartKiller

No matter if I use the FF nightly or any other browser (edge, chrome) I get a message similar to this

Sorry Firefox!
This version of Firefox doesn’t support the video features we’ll need to run this demo. You can either update Firefox to the latest nightly build here, or try again using Chrome or Safari.

or in chrome i get this

Uh oh, this browser isn’t supported.
This browser doesn’t support the video features we’ll need to run this demo. Try again using Chrome, Safari, or Firefox Nightly.
Back to homepage

a problem with me?

@heyoeyo
Copy link

heyoeyo commented Oct 1, 2024

In case it helps, both chromium v128.0.6613.119 and firefox v130.0 seem to work ok for me.

That message seems to be coming from the file:
demo/frontend/src/routes/DemoPageWrapper.tsx

So worst case, you could try faking support (i.e. change the isBrowserSupported function so it always returns true), to double check if things will work after skipping the warning.

@LongShanksBraveHeartKiller
Copy link
Author

Thanks for that heyoeyo. With that I was able to get to the next problem.. To be clear, were you able to git clone the repo, fire up docker compose build, up it, and have it just work without any issue? Thanks again

@heyoeyo
Copy link

heyoeyo commented Oct 2, 2024

To be clear, were you able to git clone the repo, fire up docker compose build, up it, and have it just work without any issue?

Yes, I haven't tried running it directly, only through docker. The only thing I did was:

docker compose up --build

It doesn't seem to be using the GPU so it runs painfully slow, but otherwise, there weren't any issues building/running it. For reference, my docker/compose versions are:

$ docker --version
Docker version 27.2.0, build 3ab4256

$ docker compose version
Docker Compose version v2.29.2

Edit: This is all running on a linux system, which may explain the discrepancies, based on the post from @tungtrandt13.

@LongShanksBraveHeartKiller
Copy link
Author

oh interesting. I finally got it to work by modifying a few things. First I had to go into backend app.py and add my localhost and subnet as origins. Secondly I had to ensure FLASK-CORS was being installed in the docker container. Weird. For the GPU problem you are having you need to add this to your docker compose (or modify to meet your specific condition) Previously with docker-compose you could add the -gpus all flag but now you need to specify within the compose.yml (I guess)

  - VIDEO_ENCODE_VERBOSE=False
  - FFMPEG_NUM_THREADS=4
deploy:
  resources:
    reservations:
      devices:
        - capabilities: [gpu]

x-environment:
NVIDIA_VISIBLE_DEVICES: all
NVIDIA_DRIVER_CAPABILITIES: compute,utility,video

@tungtrandt13
Copy link

Some api properties in windows are only available with https. So everyone should edit the browser to support this section VideoEncoder

@nicholasbulka
Copy link

My issue is connecting to the graphql running on port 7263. I am not familiar with graphql, so maybe I am missing something easy?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants