Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should add Lambda(lambda x: x/255.0) in tutorial #32

Closed
jiarenyf opened this issue Apr 29, 2021 · 6 comments
Closed

Should add Lambda(lambda x: x/255.0) in tutorial #32

jiarenyf opened this issue Apr 29, 2021 · 6 comments
Assignees
@nateraw
Labels
bug Something isn't working question Further information is requested

Comments

@jiarenyf
Copy link

Should add Lambda(lambda x: x/255.0) in tutorial, right ?
@kalyanvasudev kalyanvasudev added bug Something isn't working question Further information is requested labels May 12, 2021
@kalyanvasudev
Copy link
Contributor

Yes, it does seem like we are missing the lambda scaling transform.

@tullie , could you please confirm this? We seem to have this transform for Pytorchvideo models in PySlowFast - https://github.com/facebookresearch/SlowFast/blob/master/slowfast/datasets/ptv_datasets.py#L194

@tullie
Copy link
Contributor

tullie commented May 14, 2021

Yep you're right! Great catch. Will send out a change for this.

@nateraw
Copy link
Contributor

nateraw commented May 20, 2021 •
edited
Loading

@tullie feel free to assign this to me 😄 . Can be incorporated w/ changes I'm making in #41 . Or can do separate PR if you'd like that better.

@tullie
Copy link
Contributor

tullie commented May 20, 2021

That sounds good @nateraw!

@tullie tullie assigned nateraw and unassigned tullie May 20, 2021
@kalyanvasudev
Copy link
Contributor

@nateraw, it would be helpful if you could do a separate quick PR for this issue and tag the issue in the PR. This way, it will be better documented and sets up a nice example workflow for other contributors to follow :) Thanks a lot!

@nateraw nateraw mentioned this issue May 24, 2021
Closed
11 tasks
@nateraw
Copy link
Contributor

nateraw commented May 24, 2021

@kalyanvasudev done! 😄

xianyuanliu pushed a commit to xianyuanliu/pytorchvideo that referenced this issue Dec 28, 2021
@tullie @facebook-github-bot
Add data preparation to tutorial (facebookresearch#32)
4d5365f 
Summary:
## Motivation and Context

Users seem to not understand how to download the data exactly.

Pull Request resolved: fairinternal/pytorchvideo#32

Reviewed By: kalyanvasudev

Differential Revision: D27814288

Pulled By: tullie

fbshipit-source-id: 8ddb1470d924758388950e8ed5cd680c1bd0ef81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nateraw nateraw

Labels
bug Something isn't working question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing lambda to transforms in tutorial nateraw/pytorchvideo
4 participants
@tullie @jiarenyf @kalyanvasudev @nateraw