Skip to content
This repository was archived by the owner on Jun 20, 2025. It is now read-only.

Commit 37f102f

Browse files
musebcfacebook-github-bot
authored andcommitted
Support custom test configurations in the PL Test Runner (#2246)
Summary: Pull Request resolved: #2246 ## Context Right now we have 3 different test runner workflow to essentially just change which config they use. ## This Diff This diff updates the main PL E2E workflow to support a config parameter so we can run all PL tests on it and deprecate the other two workflows. Reviewed By: ajinkya-ghonge Differential Revision: D44433105 fbshipit-source-id: 2a95a073170e075b0457560d9622631530006a79
1 parent c08a437 commit 37f102f

File tree

1 file changed

+14
-2
lines changed

1 file changed

+14
-2
lines changed

.github/workflows/one_command_runner_test.yml

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: One command runner test
1+
name: Private Lift Test
22
run-name: ${{ inputs.test_name }} on ${{ inputs.tag }} for build ${{ inputs.build_id }}
33

44
on:
@@ -41,6 +41,11 @@ on:
4141
description: The name of the type of tests that are being run
4242
default: 'PL E2E Tests'
4343
type: string
44+
test_config:
45+
description: The yaml file name that will be passed in the --config parameter to the E2E runner
46+
default: 'config_one_command_runner_test.yml'
47+
type: string
48+
required: true
4449
tracker_hash:
4550
description: '[Internal usage] Used for tracking workflow job status within Meta infra'
4651
required: false
@@ -84,6 +89,12 @@ on:
8489
options:
8590
- PL E2E Tests
8691
- Multi-key PL E2E Tests
92+
- UDP Tests
93+
test_config:
94+
description: The yaml file name that will be passed in the --config parameter to the E2E runner
95+
default: 'config_one_command_runner_test.yml'
96+
type: string
97+
required: false
8798
tracker_hash:
8899
description: '[Internal usage] Used for tracking workflow job status within Meta infra'
89100
required: false
@@ -94,6 +105,7 @@ env:
94105
FBPCS_IMAGE_NAME: pc-coordinator-prod
95106
FBPCS_GRAPH_API_TOKEN: ${{ secrets.FBPCS_GRAPH_API_TOKEN }}
96107
CONSOLE_OUTPUT_FILE: /tmp/output.txt
108+
CONFIG_YAML: ./fbpcs/tests/github/${{ inputs.test_config }}
97109

98110
jobs:
99111
### Private Lift E2E tests
@@ -132,7 +144,7 @@ jobs:
132144
${{ inputs.study_id }} \
133145
--objective_ids=${{ inputs.objective_id }} \
134146
--input_paths=${{ inputs.input_path }} \
135-
--config=./fbpcs/tests/github/config_one_command_runner_test.yml \
147+
--config="$CONFIG_YAML" \
136148
-- \
137149
--version=${{ inputs.tag }} \
138150
--image_version=${{ inputs.coordinator_tag }} \

0 commit comments

Comments
 (0)