From 2368e5dec2942faa4f98375bdde692358632e002 Mon Sep 17 00:00:00 2001 From: Richard Barnes Date: Thu, 11 Apr 2024 22:23:25 -0700 Subject: [PATCH] Remove unused variables in fbit/itstorage/data_crawler/thread/ThreadedCrawler.cpp (#2397) Summary: Pull Request resolved: https://github.com/facebookresearch/fbpcs/pull/2397 X-link: https://github.com/facebookresearch/fbpcf/pull/538 LLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance. This diff either (a) removes an unused variable and, possibly, it's associated code, or (b) qualifies the variable with `[[maybe_unused]]`, mostly in cases where the variable _is_ used, but, eg, in an `assert` statement that isn't present in production code. - If you approve of this diff, please use the "Accept & Ship" button :-) Reviewed By: palmje Differential Revision: D56022415 fbshipit-source-id: 65aa2b310e39ff134bf6dd8a82e3a539c3033660 --- .../AttributionIdSpineFileCombinerTest.cpp | 1 - .../PrivateIdDfcaIdSpineFileCombinerTest.cpp | 1 - fbpcs/emp_games/dotproduct/DotproductGame_impl.h | 1 - 3 files changed, 3 deletions(-) diff --git a/fbpcs/data_processing/attribution_id_combiner/AttributionIdSpineFileCombinerTest.cpp b/fbpcs/data_processing/attribution_id_combiner/AttributionIdSpineFileCombinerTest.cpp index c6be23555..70aa8ea94 100644 --- a/fbpcs/data_processing/attribution_id_combiner/AttributionIdSpineFileCombinerTest.cpp +++ b/fbpcs/data_processing/attribution_id_combiner/AttributionIdSpineFileCombinerTest.cpp @@ -58,7 +58,6 @@ class AttributionIdSpineFileCombinerTest : public testing::Test { std::string spineIdContentPath = "/tmp/AttributionIdSpineFileCombinerTestSpineIdContent" + std::to_string(randStart); - constexpr size_t kBufferedReaderChunkSize = 4096; data_processing::test_utils::writeVecToFile(dataContent, dataContentPath); data_processing::test_utils::writeVecToFile( spineIdContent, spineIdContentPath); diff --git a/fbpcs/data_processing/private_id_dfca_id_combiner/PrivateIdDfcaIdSpineFileCombinerTest.cpp b/fbpcs/data_processing/private_id_dfca_id_combiner/PrivateIdDfcaIdSpineFileCombinerTest.cpp index b4f44105b..87053c7a9 100644 --- a/fbpcs/data_processing/private_id_dfca_id_combiner/PrivateIdDfcaIdSpineFileCombinerTest.cpp +++ b/fbpcs/data_processing/private_id_dfca_id_combiner/PrivateIdDfcaIdSpineFileCombinerTest.cpp @@ -58,7 +58,6 @@ class PrivateIdDfcaIdSpineFileCombinerTest : public testing::Test { std::string spineIdContentPath = "/tmp/PrivateIdDfcaIdSpineFileCombinerTestSpineIdContent" + std::to_string(randStart); - constexpr size_t kBufferedReaderChunkSize = 4096; data_processing::test_utils::writeVecToFile(dataContent, dataContentPath); data_processing::test_utils::writeVecToFile( spineIdContent, spineIdContentPath); diff --git a/fbpcs/emp_games/dotproduct/DotproductGame_impl.h b/fbpcs/emp_games/dotproduct/DotproductGame_impl.h index 2f76bccc4..dd67b29eb 100644 --- a/fbpcs/emp_games/dotproduct/DotproductGame_impl.h +++ b/fbpcs/emp_games/dotproduct/DotproductGame_impl.h @@ -53,7 +53,6 @@ std::vector DotproductGame::computeDotProduct( XLOG(INFO, "Performed the OR for all labels"); constexpr uint64_t divisor = static_cast(1e9); - constexpr double tolerance = 1e-7; auto prgFactory = std::make_unique();