From fdc89fa456a311e4ec3378d9913372a561b51d88 Mon Sep 17 00:00:00 2001 From: Richard Barnes Date: Thu, 11 Apr 2024 22:23:25 -0700 Subject: [PATCH] Remove unused variables in fbit/itstorage/data_crawler/thread/ThreadedCrawler.cpp (#538) Summary: X-link: https://github.com/facebookresearch/fbpcs/pull/2397 Pull Request resolved: https://github.com/facebookresearch/fbpcf/pull/538 LLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance. This diff either (a) removes an unused variable and, possibly, it's associated code, or (b) qualifies the variable with `[[maybe_unused]]`, mostly in cases where the variable _is_ used, but, eg, in an `assert` statement that isn't present in production code. - If you approve of this diff, please use the "Accept & Ship" button :-) Reviewed By: palmje Differential Revision: D56022415 fbshipit-source-id: 65aa2b310e39ff134bf6dd8a82e3a539c3033660 --- .../unified_data_process/data_processor/DataProcessor_impl.h | 1 - 1 file changed, 1 deletion(-) diff --git a/fbpcf/mpc_std_lib/unified_data_process/data_processor/DataProcessor_impl.h b/fbpcf/mpc_std_lib/unified_data_process/data_processor/DataProcessor_impl.h index d24d056b..6d486618 100644 --- a/fbpcf/mpc_std_lib/unified_data_process/data_processor/DataProcessor_impl.h +++ b/fbpcf/mpc_std_lib/unified_data_process/data_processor/DataProcessor_impl.h @@ -23,7 +23,6 @@ typename IDataProcessor::SecString DataProcessor::processMyData( const std::vector>& plaintextData, size_t outputSize) { - size_t dataSize = plaintextData.size(); size_t dataWidth = plaintextData.at(0).size(); std::vector indexes(plaintextData.size()); // generate 0 to n-1 vector