Skip to content

Commit 90bae56

Browse files
r-barnesfacebook-github-bot
authored andcommitted
Remove unused variables in fbpcf/mpc_std_lib/unified_data_process/serialization/RowStructureDefinition.h
Summary: LLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance. This diff either (a) removes an unused variable and, possibly, it's associated code, or (b) qualifies the variable with `[[maybe_unused]]`, mostly in cases where the variable _is_ used, but, eg, in an `assert` statement that isn't present in production code. - If you approve of this diff, please use the "Accept & Ship" button :-) Reviewed By: palmje Differential Revision: D53779568
1 parent c82f824 commit 90bae56

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

fbpcf/mpc_std_lib/unified_data_process/serialization/RowStructureDefinition.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,6 @@ class RowStructureDefinition : public IRowStructureDefinition<schedulerId> {
158158
columnDefinition : *columnDefinitions_.get()) {
159159
const IColumnDefinition<schedulerId>* columnPointer =
160160
columnDefinition.get();
161-
auto columnType = columnDefinition->getColumnType();
162161

163162
if (columnDefinition->getColumnType() ==
164163
IColumnDefinition<

0 commit comments

Comments
 (0)