From 76ee6a90a8b0a9d83ef0d4fdf9a98c83ee3778dd Mon Sep 17 00:00:00 2001 From: Zhenhuan Zhang Date: Wed, 21 Feb 2024 15:56:13 -0800 Subject: [PATCH] Fix unsafe fallthrough at fbcode/fbpcf/scheduler/gate_keeper/BatchCompositeGate.h:63 (#533) Summary: Pull Request resolved: https://github.com/facebookresearch/fbpcf/pull/533 details in T179856888 **context** LLVM has detected an implicit fallthrough near fbcode/fbpcf/scheduler/gate_keeper/BatchCompositeGate.h:63. Implicit fallthroughs have a very high bug rate, so we are making them a compiler error by default. Reviewed By: ztlbells Differential Revision: D54025656 fbshipit-source-id: 4a2c501c17063b2bb0a91489df169544b59ab75f --- fbpcf/scheduler/gate_keeper/BatchCompositeGate.h | 1 + 1 file changed, 1 insertion(+) diff --git a/fbpcf/scheduler/gate_keeper/BatchCompositeGate.h b/fbpcf/scheduler/gate_keeper/BatchCompositeGate.h index c6cbdfdc..f98edf0f 100644 --- a/fbpcf/scheduler/gate_keeper/BatchCompositeGate.h +++ b/fbpcf/scheduler/gate_keeper/BatchCompositeGate.h @@ -58,6 +58,7 @@ class BatchCompositeGate final : public ICompositeGate { engine.computeBatchFreeAND( leftValues, wireKeeper_.getBatchBooleanValue(rights_[i]))); } + break; } case GateType::NonFreeAnd: {