Merge pull request #524 from facebookresearch/shut-up-warnings

Shut up some -Wsign-compare warnings

Author: ftynse

CMakeLists.txt

@@ -315,8 +315,8 @@ if (WITH_CAFFE2 AND WITH_CUDA)
    message(STATUS "Found, CAFFE2_INCLUDE_DIR: " ${CAFFE2_INCLUDE_DIR})
 
    add_definitions(-DCAFFE2_USE_GOOGLE_GLOG)
-   include_directories(AFTER ${EIGEN_INCLUDE_DIR})
-   include_directories(AFTER ${CAFFE2_INCLUDE_DIR})
+   include_directories(AFTER SYSTEM ${EIGEN_INCLUDE_DIR})
+   include_directories(AFTER SYSTEM ${CAFFE2_INCLUDE_DIR})
    add_subdirectory(tc/c2)
    add_subdirectory(tc/benchmarks)
    add_subdirectory(test/caffe2)

tc/benchmarks/MLP_model.cc

@@ -286,8 +286,8 @@ void ProductionModel::runATen1LUT() {
 }
 
 void ProductionModel::run2LUT(const tc::CudaMappingOptions& options) {
-  TC_CHECK_LT(0, E1);
-  TC_CHECK_LT(0, E2);
+  TC_CHECK_LT(0u, E1);
+  TC_CHECK_LT(0u, E2);
   auto ws_init_func = [=](Workspace& w) {
     AddDeterministicallyRandomInput<caffe2::CUDABackend, float>(
         w, {E1, D}, "LUT1");

tc/benchmarks/benchmark_fixture.h

@@ -65,11 +65,11 @@ struct Benchmark : public ::testing::Test {
   void SetUp() {
     if (!FLAGS_disable_version_checks) {
       auto cudnnVersion = cudnnGetVersion();
-      TC_CHECK_LE(6021, cudnnVersion)
+      TC_CHECK_LE(6021u, cudnnVersion)
           << "[CUDNN][VERSION] Enforce version compatibility check";
 
       auto cudaRtVersion = cudnnGetCudartVersion();
-      TC_CHECK_LE(8000, cudaRtVersion)
+      TC_CHECK_LE(8000u, cudaRtVersion)
           << "[CUDART][VERSION] Enforce version compatibility check";
 
       int cublasVersion;