{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":277455670,"defaultBranch":"main","name":"Private-ID","ownerLogin":"facebookresearch","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2020-07-06T06:01:06.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/16943930?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1723115257.0","currentOid":""},"activityList":{"items":[{"before":"1ab1af7b5df9502a236d906e9c1874888d7d6ff2","after":"eb536988ef3655df838d0245719d1230c433d240","ref":"refs/heads/main","pushedAt":"2024-08-08T10:59:47.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Back out \"Upgrade the Rust aws-sdk-gamelift crate to latest (1.38.0) and upgrade the rest of the AWS crates to the versions that were released alongside it\"\n\nSummary:\nReverting the stack D60582035 because it breaks buck2. [Writeup](https://fb.workplace.com/groups/476440319183141/posts/2722556804571470)\n\nOriginal commit changeset: 81bf9f3ec41a\n\nOriginal Phabricator Diff: D60582035\n\nallow-large-files\nbypass_size_limit\n\nReviewed By: JakobDegen\n\nDifferential Revision: D60949984\n\nfbshipit-source-id: de92d8f781bd05d83a57267e038cd5d393ecc4e5","shortMessageHtmlLink":"Back out \"Upgrade the Rust aws-sdk-gamelift crate to latest (1.38.0) …"}},{"before":"58af4eff6e2add0e46c88fb844bdab702954555f","after":"1ab1af7b5df9502a236d906e9c1874888d7d6ff2","ref":"refs/heads/main","pushedAt":"2024-08-07T12:34:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Upgrade the Rust aws-sdk-gamelift crate to latest (1.38.0) and upgrade the rest of the AWS crates to the versions that were released alongside it\n\nSummary:\n[release-2024-07-29](https://github.com/awslabs/aws-sdk-rust/releases/tag/release-2024-07-29) is the aws-sdk-rust release that the other crates' versions were pulled from.\n\n**Why?**\n\nI need [CreateFleet](https://docs.aws.amazon.com/gamelift/latest/apireference/API_CreateFleet.html)'s [InstanceRoleCredentialsProvider](https://docs.aws.amazon.com/gamelift/latest/apireference/API_CreateFleet.html#gamelift-CreateFleet-request-InstanceRoleCredentialsProvider) parameter.\n\n**Changes**\n\n* The new AWS SDK requires ring 0.17.5 or later, so ring was upgraded from 0.17.3 to 0.17.8 and I had to add fixups to get it building for Windows.\n* [aws-smithy-client](https://crates.io/crates/aws-smithy-client) was replaced by [aws-smithy-runtime](https://crates.io/crates/aws-smithy-runtime) and [aws-smithy-runtime-api](https://crates.io/crates/aws-smithy-runtime-api).\n* ```aws_smithy_http::body``` was moved to ```aws_smithy_types::body```.\n* ```aws_smithy_http::byte_stream``` was moved to ```aws_smithy_types::byte_stream```.\n* Struct members modeled as required are no longer wrapped in ```Option```s [when possible](https://smithy.io/2.0/spec/aggregate-types.html#structure-member-optionality).\n\nallow-large-files\nbypass_size_limit\n\nApproved commit size limit bypass request: https://fb.workplace.com/groups/scm/permalink/7831552160227669/\n\nReviewed By: dtolnay\n\nDifferential Revision: D60582035\n\nfbshipit-source-id: 81bf9f3ec41abed20a6a6fa109d0509c447227fa","shortMessageHtmlLink":"Upgrade the Rust aws-sdk-gamelift crate to latest (1.38.0) and upgrad…"}},{"before":"b9200ff5ecb2e9035936af9aff1b1b98e5e96abb","after":"58af4eff6e2add0e46c88fb844bdab702954555f","ref":"refs/heads/main","pushedAt":"2024-01-10T07:03:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"format_code_in_doc_comments = true\n\nSummary:\nAnother attempt to enable the option.\n\n[We agreed](https://fb.workplace.com/groups/rust.language/posts/24184800024475285) we want it everywhere by default.\n\n# Help us, help yourself\n\nIf you can help enabling this option, consider running this command ahead of time:\n\n```\nhg files . -I 'your_project/**/*.rs' | \\\n xargs arc rustfmt --config format_code_in_doc_comments=true\n```\n\nFix the which is not landed yet:\n\n```\nhg st --rev .~1 -n -ma -I '**/*.rs' | \\\n xargs arc rustfmt --config format_code_in_doc_comments=true\n```\n\nFix the stack of commits: checkout the top commit, and then:\n```\n# must include changes from D52632478\nfbcode/scripts/nga/stack-rustfmt-new\n```\n\n# Previous attempt\n\nD42766542\n\nReviewed By: zertosh, dtolnay\n\nDifferential Revision: D52632085\n\nfbshipit-source-id: f45998c76076470d66339eb99f585856d2114999","shortMessageHtmlLink":"format_code_in_doc_comments = true"}},{"before":"fe511dccd70084eeee85c8871792377f66058f1e","after":"b9200ff5ecb2e9035936af9aff1b1b98e5e96abb","ref":"refs/heads/main","pushedAt":"2024-01-10T00:09:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"format_code_in_doc_comments = true\n\nSummary: D52632085\n\nReviewed By: zertosh\n\nDifferential Revision: D52639960\n\nfbshipit-source-id: c659c45c7b1752b556ffce3d1ee65faed01b8e87","shortMessageHtmlLink":"format_code_in_doc_comments = true"}},{"before":"e82deba1b23f7a2b1309a212797a55c8ef040d8c","after":"fe511dccd70084eeee85c8871792377f66058f1e","ref":"refs/heads/main","pushedAt":"2023-12-26T04:19:54.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Update README and fix issue in one-to-many matches (#121)\n\nSummary:\n## Types of changes\n\nFixed small issue in one-to-many matching and update README.\n\n- [x] Bug fix (non-breaking change which fixes an issue)\n- [ ] New feature (non-breaking change which adds functionality)\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\n- [x] Docs change / refactoring / dependency upgrade\n\n## Motivation and Context / Related issue\n\nAddressed some PETS reviews.\n\n## How Has This Been Tested (if it applies)\n\nTests pass.\n\n## Checklist\n\n- [x] The documentation is up-to-date with the changes I made.\n- [x] I have read the **CONTRIBUTING** document and completed the CLA (see **CONTRIBUTING**).\n- [x] All tests passed, and additional code has been covered with new tests.\n\nPull Request resolved: https://github.com/facebookresearch/Private-ID/pull/121\n\nReviewed By: shubho\n\nDifferential Revision: D52354667\n\nPulled By: prasadbuddhavarapu\n\nfbshipit-source-id: 6d8a6ccd035334e2a3b31e69b9ae6f2f40b2c936","shortMessageHtmlLink":"Update README and fix issue in one-to-many matches (#121)"}},{"before":null,"after":"5494cf24607592df4a42035182feaf740831c5cd","ref":"refs/heads/minor-fixes","pushedAt":"2023-12-19T00:48:44.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jimouris","name":"Dimitris Mouris","path":"/jimouris","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7729748?s=80&v=4"},"commit":{"message":"Update README and fix issue in one-to-many matches","shortMessageHtmlLink":"Update README and fix issue in one-to-many matches"}},{"before":"f8bb64d89a8a4b487fa698553d69df3cf984fb40","after":null,"ref":"refs/heads/fixup-T170770305-main","pushedAt":"2023-11-22T16:02:24.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"bigfootjon","name":"Jon Janzen","path":"/bigfootjon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6403568?s=80&v=4"}},{"before":"932915c37d08e42bdbc630e03d0f8e1a39ec962e","after":"e82deba1b23f7a2b1309a212797a55c8ef040d8c","ref":"refs/heads/main","pushedAt":"2023-11-22T16:02:20.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"bigfootjon","name":"Jon Janzen","path":"/bigfootjon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6403568?s=80&v=4"},"commit":{"message":"Re-sync with internal repository (#120)\n\nThe internal and external repositories are out of sync. This Pull Request attempts to brings them back in sync by patching the GitHub repository. Please carefully review this patch. You must disable ShipIt for your project in order to merge this pull request. DO NOT IMPORT this pull request. Instead, merge it directly on GitHub using the MERGE BUTTON. Re-enable ShipIt after merging.","shortMessageHtmlLink":"Re-sync with internal repository (#120)"}},{"before":null,"after":"f8bb64d89a8a4b487fa698553d69df3cf984fb40","ref":"refs/heads/fixup-T170770305-main","pushedAt":"2023-11-22T15:51:24.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Re-sync with internal repository\n\nThe internal and external repositories are out of sync. This Pull Request attempts to brings them back in sync by patching the GitHub repository. Please carefully review this patch. You must disable ShipIt for your project in order to merge this pull request. DO NOT IMPORT this pull request. Instead, merge it directly on GitHub using the MERGE BUTTON. Re-enable ShipIt after merging.","shortMessageHtmlLink":"Re-sync with internal repository"}},{"before":"f1cda2b7bfb58eca626195c862bc198e77edcdb9","after":"932915c37d08e42bdbc630e03d0f8e1a39ec962e","ref":"refs/heads/main","pushedAt":"2023-11-22T07:29:19.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Update dependencies (#117)\n\nSummary:\n## Types of changes\n\n- [ ] Bug fix (non-breaking change which fixes an issue)\n- [ ] New feature (non-breaking change which adds functionality)\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\n- [x] Docs change / refactoring / dependency upgrade\n\n## Motivation and Context / Related issue\n\nUpdate dependencies and remove some unused ones.\n\ncc: prasadbuddhavarapu shubho The file `protocol/src/suid_create/mod.rs` in line 163 is using `BASEPOINT_ORDER` which [curve25519_dalek](https://docs.rs/curve25519-dalek/4.1.1/curve25519_dalek/index.html#) after version 4 does not consider in the public API. Check [here](https://docs.rs/curve25519-dalek/4.1.1/curve25519_dalek/constants/constant.BASEPOINT_ORDER.html). I haven't changed that as it's part of the SUID protocol. It works fine but it throws a warning.\n\n## Checklist\n\n- [x] The documentation is up-to-date with the changes I made.\n- [x] I have read the **CONTRIBUTING** document and completed the CLA (see **CONTRIBUTING**).\n- [x] All tests passed, and additional code has been covered with new tests.\n\nPull Request resolved: https://github.com/facebookresearch/Private-ID/pull/117\n\nReviewed By: zertosh, shubho\n\nDifferential Revision: D51293836\n\nPulled By: prasadbuddhavarapu\n\nfbshipit-source-id: edb67f028f103850f4d1e6595296c9afa705840a","shortMessageHtmlLink":"Update dependencies (#117)"}},{"before":"26b08dd59182cb835b94ca926dd4e8f624108a83","after":"f1cda2b7bfb58eca626195c862bc198e77edcdb9","ref":"refs/heads/main","pushedAt":"2023-11-16T15:36:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"clippy: prevent holding a span guard over an `.await` (#119)\n\nSummary:\nPull Request resolved: https://github.com/facebookresearch/Private-ID/pull/119\n\nWe should probably lint against using an `.enter()` guard over `.await` points for the reasons outlined in https://docs.rs/tracing/latest/tracing/struct.Span.html#in-asynchronous-code.\n\nReviewed By: zertosh\n\nDifferential Revision: D50528695\n\nfbshipit-source-id: 82fcc97a83b5d820c8673e6f56794dc47fd4d77f","shortMessageHtmlLink":"clippy: prevent holding a span guard over an .await (#119)"}},{"before":"b27743a2fd5f4a6bb2fd0c180724fdbf36af4725","after":"26b08dd59182cb835b94ca926dd4e8f624108a83","ref":"refs/heads/main","pushedAt":"2023-11-14T02:18:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Delegated Private Matching for Compute (DPMC) (#116)\n\nSummary:\n## Types of changes\n\n- [ ] Bug fix (non-breaking change which fixes an issue)\n- [x] New feature (non-breaking change which adds functionality)\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\n- [ ] Docs change / refactoring / dependency upgrade\n\n## Motivation and Context / Related issue\n\n1) Extending multi-key Private-ID to Delegated Private Matching for Compute (DPMC) which supports multiple partners with the help of a helper/delegate server.\n\n* Company has a csv with identifiers (e.g., `etc/example/dpmc/Ex0_company.csv`).\n* Partner has a csv with identifiers (e.g., `etc/example/dpmc/Ex0_partner_1.csv`) and a csv with features (e.g., `etc/example/dpmc/Ex0_partner_1_features.csv`).\n\n2) Extending DPMC to Delegated Private Matching for Compute with Secure Shuffling (DSPMC) which supports multiple partners with the help of two helpers/delegate servers.\n\n* Company has a csv with identifiers (e.g., `etc/example/dspmc/Ex0_company.csv`).\n* Partner has a csv with identifiers (e.g., `etc/example/dspmc/Ex0_partner_1.csv`) and a csv with features (e.g., `etc/example/dspmc/Ex0_partner_1_features.csv`).\n\n## How Has This Been Tested (if it applies)\n\nTests are located in `etc/example/dpmc` and `etc/example/dspmc`.\n\n## Checklist\n\n- [x] The documentation is up-to-date with the changes I made.\n- [x] I have read the **CONTRIBUTING** document and completed the CLA (see **CONTRIBUTING**).\n- [x] All tests passed, and additional code has been covered with new tests.\n\nPull Request resolved: https://github.com/facebookresearch/Private-ID/pull/116\n\nReviewed By: shubho\n\nDifferential Revision: D50680360\n\nPulled By: prasadbuddhavarapu\n\nfbshipit-source-id: 3f82635e61ee86c8041864d3bbb3f293df3996d8","shortMessageHtmlLink":"Delegated Private Matching for Compute (DPMC) (#116)"}},{"before":"9b1a2fc7473eeb268afe55b4bda770531c22a013","after":"b27743a2fd5f4a6bb2fd0c180724fdbf36af4725","ref":"refs/heads/main","pushedAt":"2023-07-24T17:47:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Update AWS SDKs to 0.28.0 and libs to 0.55.3 (#115)\n\nSummary:\nPull Request resolved: https://github.com/facebookresearch/Private-ID/pull/115\n\n* After adding the GameLift SDK, we (Ready At Dawn) realized that the OperatingSystem enum in 0.24.0 is missing the Windows2016 variant we need for our game servers. This update to 0.28 brings that in and gets everything up to date.\n* Fix up the things I could find that stopped building after upgrading\n\nallow-large-files\n\nReviewed By: dtolnay\n\nDifferential Revision: D47639814\n\nfbshipit-source-id: 8096723803b41b5b917c222a13d569e05d2e412a","shortMessageHtmlLink":"Update AWS SDKs to 0.28.0 and libs to 0.55.3 (#115)"}},{"before":"d4eba22a9cc31fcbc87e164a7fe1a771ee418dcc","after":"9b1a2fc7473eeb268afe55b4bda770531c22a013","ref":"refs/heads/main","pushedAt":"2023-03-23T11:49:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Panic with clear message when tonic_build OUT env is not set\n\nSummary:\nI was sloppy in D44322620 and:\n\n1. Used `std::env::var` instead of `std::env::var_os`. The former does\n `OsString` to `String` conversion, which we don't care about because\n `.out_dir` expects `AsRef`.\n2. Used `.unwrap` without including a message as to what expectation is\n being violated.\n\nIn D44324686 I was sloppy by leaving a needless borrow.\n\nReviewed By: yuyashiraki\n\nDifferential Revision: D44324930\n\nfbshipit-source-id: f5b0152793d8537c70398ed83402fb6301b72f16","shortMessageHtmlLink":"Panic with clear message when tonic_build OUT env is not set"}},{"before":"28cf26daa5db0e16cd19caeeb784ab1fb52b4866","after":"d4eba22a9cc31fcbc87e164a7fe1a771ee418dcc","ref":"refs/heads/main","pushedAt":"2023-03-23T03:16:20.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix tonic_build OSS build\n\nReviewed By: capickett\n\nDifferential Revision: D44324686\n\nfbshipit-source-id: 930a442bed79bcee3f17cd7e984963fa78ea27c4","shortMessageHtmlLink":"Fix tonic_build OSS build"}},{"before":"8184dce1025c9f88e78936ca43a386eb8484db88","after":"28cf26daa5db0e16cd19caeeb784ab1fb52b4866","ref":"refs/heads/main","pushedAt":"2023-03-23T01:10:04.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix tonic_build builds\n\nReviewed By: yuyashiraki\n\nDifferential Revision: D44322620\n\nfbshipit-source-id: c0d8654cec2fe9d6621dca0fdf854404cfd9b60c","shortMessageHtmlLink":"Fix tonic_build builds"}},{"before":"9fe7c74fb5866caecf1ca8356c5382614563d2bd","after":"8184dce1025c9f88e78936ca43a386eb8484db88","ref":"refs/heads/main","pushedAt":"2023-03-11T03:27:31.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add support for clippy.toml configuration file\n\nSummary: I am interested in running clippy under buck2 in CI for https://github.com/dtolnay/cxx, but I need it to be configured with `msrv = \"...\"` the same as my Cargo builds.\n\nReviewed By: diliop\n\nDifferential Revision: D43991741\n\nfbshipit-source-id: c9a6a923651cebf5f24a48c6cd5daac0631cb763","shortMessageHtmlLink":"Add support for clippy.toml configuration file"}},{"before":"c2f55d5f2b5167edf405637b2e2049abe71e5c91","after":"9fe7c74fb5866caecf1ca8356c5382614563d2bd","ref":"refs/heads/main","pushedAt":"2023-03-07T22:44:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"update all aws sdks, and update code that the update broke (#114)\n\nSummary:\nPull Request resolved: https://github.com/facebookresearch/Private-ID/pull/114\n\nX-link: https://github.com/facebook/hhvm/pull/9346\n\nallow-large-files\n\n**What?**\n\nI'm updating all Rust AWS service SDKs to latest (0.24) and all library SDKs to latest (0.54.1), and fixing some code that broke as a result of that\n\nDifferential Revision: D43720681\n\nfbshipit-source-id: 8b025dc64f640810e6ebbd384f2a2ac643ce9eeb","shortMessageHtmlLink":"update all aws sdks, and update code that the update broke (#114)"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAElSUYAgA","startCursor":null,"endCursor":null}},"title":"Activity · facebookresearch/Private-ID"}