Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Benchmark build failure by class DwrfStreamIdentifier #12113

Open
jinchengchenghh opened this issue Jan 17, 2025 · 1 comment
Open

Github Benchmark build failure by class DwrfStreamIdentifier #12113

jinchengchenghh opened this issue Jan 17, 2025 · 1 comment
Labels
build triage Newly created issue that needs attention.

Comments

@jinchengchenghh
Copy link
Contributor

Problem description

https://github.com/facebookincubator/velox/actions/runs/12823939349/job/35759249260?pr=11869

Werror -O3 -DNDEBUG -std=gnu++17 -fPIC -fdiagnostics-color=always -pthread -MD -MT velox/dwio/dwrf/common/CMakeFiles/velox_dwio_dwrf_common.dir/Common.cpp.o -MF velox/dwio/dwrf/common/CMakeFiles/velox_dwio_dwrf_common.dir/Common.cpp.o.d -o velox/dwio/dwrf/common/CMakeFiles/velox_dwio_dwrf_common.dir/Common.cpp.o -c /home/runner/work/velox/velox/velox/velox/dwio/dwrf/common/Common.cpp
In file included from ../../velox/dwio/dwrf/common/Common.h:25,
                 from ../../velox/dwio/dwrf/common/Common.cpp:17:
../../velox/dwio/common/StreamIdentifier.h:40:16: error: ‘virtual bool facebook::velox::dwio::common::StreamIdentifier::operator==(const facebook::velox::dwio::common::StreamIdentifier&) const’ was hidden [-Werror=overloaded-virtual=]
   40 |   virtual bool operator==(const StreamIdentifier& other) const {
      |                ^~~~~~~~
../../velox/dwio/dwrf/common/Common.h:203:8: note:   by ‘bool facebook::velox::dwrf::DwrfStreamIdentifier::operator==(const facebook::velox::dwrf::DwrfStreamIdentifier&) const’
  203 |   bool operator==(const DwrfStreamIdentifier& other) const {
      |        ^~~~~~~~
cc1plus: all warnings being treated as errors

System information

https://github.com/facebookincubator/velox/actions/runs/12823939349/job/35759249260?pr=11869

CMake log

@jinchengchenghh jinchengchenghh added build triage Newly created issue that needs attention. labels Jan 17, 2025
@jinchengchenghh jinchengchenghh changed the title Github Benchmark build failure by class Github Benchmark build failure by class DwrfStreamIdentifier Jan 17, 2025
@jinchengchenghh
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build triage Newly created issue that needs attention.
Projects
None yet
Development

No branches or pull requests

1 participant