Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestCacheEviction fails on 32-bit architectures. #169

Open
skogtwin opened this issue Jan 5, 2021 · 1 comment
Open

TestCacheEviction fails on 32-bit architectures. #169

skogtwin opened this issue Jan 5, 2021 · 1 comment

Comments

@skogtwin
Copy link
Contributor

skogtwin commented Jan 5, 2021

Thanks for the fix! Unfortunately it looks like something else is amiss here. If I apply that patch I don't get the segfault anymore, but the test still fails:

      testing: github.com/facebookincubator/nvdtools
github.com/facebookincubator/nvdtools/cmd/cpe2cve
PASS
ok  	github.com/facebookincubator/nvdtools/cmd/cpe2cve	0.008s
github.com/facebookincubator/nvdtools/cmd/csv2cpe
PASS
ok  	github.com/facebookincubator/nvdtools/cmd/csv2cpe	0.005s
github.com/facebookincubator/nvdtools/cmd/redhat_filter
PASS
ok  	github.com/facebookincubator/nvdtools/cmd/redhat_filter	0.005s
github.com/facebookincubator/nvdtools/cmd/rpm2cpe
PASS
ok  	github.com/facebookincubator/nvdtools/cmd/rpm2cpe	0.004s
github.com/facebookincubator/nvdtools/cmd/wfnconvert
PASS
ok  	github.com/facebookincubator/nvdtools/cmd/wfnconvert	0.005s
github.com/facebookincubator/nvdtools/cpedict
PASS
ok  	github.com/facebookincubator/nvdtools/cpedict	0.006s
github.com/facebookincubator/nvdtools/cvefeed
--- FAIL: TestCacheEviction (0.00s)
    eviction_test.go:64: concurrent run: cache size 1758/2048; 2 records cached
    eviction_test.go:91: sequential run #1: more than 1 record cached (2)
    eviction_test.go:93: sequential run #1: cache size 2046/2048; 2 records cached
    eviction_test.go:122: sequentual run #2: cache size 1704/2048; 8 records cached
FAIL
exit status 1
FAIL	github.com/facebookincubator/nvdtools/cvefeed	0.022s

Full build output is at https://kojipkgs.fedoraproject.org//work/tasks/6747/58936747/build.log for i686, https://koji.fedoraproject.org/koji/taskinfo?taskID=58936690 is the build task with all platforms.

Originally posted by @davide125 in #167 (comment)

@skogtwin
Copy link
Contributor Author

skogtwin commented Jan 5, 2021

Cache capacity in records is hard-coded in the test. Since the record is smaller on 32-bit archs, the test fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant