Skip to content

Issues with the new release #1318

Description

@xK7mQ2pLvR3n

Did brew upgrade yesterday and ran into at least two issues which make it a bit hard to use.

Issue 1: sl pull exits 255

Potential root cause: The post-pull prmarker hook (sapling.ext.github.pr_marker.cleanup_landed_pr_hook) spawns gh with a sanitized PATH (/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin) that excludes /home/linuxbrew/.linuxbrew/bin where gh actually lives. Every draft commit's PR lookup raises FileNotFoundError, the hook returns 255, and sl pull propagates that.

Temporary workaround: apply in ~/.config/sapling/sapling.conf:

[github]
hide-landed-commits = false

Issue 2: sl metaedit doesn't work

It opens an editor as usual, but once I make edits, save and quit the editor, it exits again with 255, and the changes are not preserved. Might be related to munmap-segv-example/README.md but I don't know.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions