Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot inherit from final 'com.facebook.react.views.imagehelper.ImageSource' #46077

Closed
wangzhi17 opened this issue Aug 17, 2024 · 7 comments
Closed
Assignees
Labels
Component: Image Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue. Resolution: PR Submitted A pull request with a fix has been provided. Type: New Architecture Issues and PRs related to new architecture (Fabric/Turbo Modules)

Comments

@wangzhi17
Copy link

Description

Using the new architecture on react native version 0.75.1, the react native fast Image library cannot be used.

Steps to reproduce

....

React Native Version

0.75.1

Affected Platforms

Runtime - Android

Areas

Fabric - The New Renderer

Output of npx react-native info

System:
  OS: macOS 13.6.7
  CPU: (10) arm64 Apple M1 Max
  Memory: 75.11 MB / 32.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 18.20.3
    path: ~/.nvm/versions/node/v18.20.3/bin/node
  Yarn:
    version: 3.6.4
    path: ~/.nvm/versions/node/v18.20.3/bin/yarn
  npm:
    version: 10.7.0
    path: ~/.nvm/versions/node/v18.20.3/bin/npm
  Watchman:
    version: 2024.06.10.00
    path: /opt/homebrew/bin/watchman
Managers:
  CocoaPods:
    version: 1.15.2
    path: /opt/homebrew/bin/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 23.2
      - iOS 17.2
      - macOS 14.2
      - tvOS 17.2
      - visionOS 1.0
      - watchOS 10.2
  Android SDK: Not Found
IDEs:
  Android Studio: 2024.1 AI-241.18034.62.2411.12071903
  Xcode:
    version: 15.2/15C500b
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 11.0.23
    path: /usr/bin/javac
  Ruby:
    version: 2.6.10
    path: /usr/bin/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.3.1
    wanted: 18.3.1
  react-native:
    installed: 0.75.1
    wanted: 0.75.1
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: true
iOS:
  hermesEnabled: true
  newArchEnabled: false

Stacktrace or Logs

Cannot inherit from final 'com.facebook.react.views.imagehelper.ImageSource'

Reproducer

...

Screenshots and Videos

No response

@wangzhi17 wangzhi17 added Needs: Triage 🔍 Type: New Architecture Issues and PRs related to new architecture (Fabric/Turbo Modules) labels Aug 17, 2024
@react-native-bot
Copy link
Collaborator

⚠️ Missing Reproducible Example
ℹ️ We could not detect a reproducible example in your issue report. Please provide either:
  • If your bug is UI related: a Snack
  • If your bug is build/update related: use our Reproducer Template. A reproducer needs to be in a GitHub repository under your username.

@react-native-bot react-native-bot added Needs: Author Feedback Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue. labels Aug 17, 2024
@react-native-bot
Copy link
Collaborator

⚠️ Missing Reproducible Example
ℹ️ We could not detect a reproducible example in your issue report. Please provide either:

@wangzhi17
Copy link
Author

@github-actions github-actions bot added Needs: Attention Issues where the author has responded to feedback. and removed Needs: Author Feedback labels Aug 17, 2024
@Boscotec
Copy link

Boscotec commented Aug 17, 2024

Temporary Workaround

DylanVann/react-native-fast-image#1043 (comment)

@TheRogue76
Copy link
Contributor

Looking at #44001, the only change that i can see is that the API has decided that it is to be marked as final, which is interesting. @andrewdacenko, i see this was your commit. Can you provide us with the context on why it was marked as final when migrating from Java to Kotlin? Was this an accidental thing or do you guys think this API should be final moving forward?

@hpanwar521
Copy link

i am getting the same error
Uploading Screenshot 2024-08-18 at 8.00.41 PM.png…

@cortinico cortinico self-assigned this Aug 19, 2024
@cortinico cortinico added Resolution: PR Submitted A pull request with a fix has been provided. and removed Needs: Attention Issues where the author has responded to feedback. labels Aug 19, 2024
cortinico added a commit to cortinico/react-native that referenced this issue Aug 19, 2024
Summary:
Fixes facebook#46077

Changelog:
[Android] [Fixed] - Make Imagesource `open` for inheritance

Differential Revision: D61469357
cortinico added a commit that referenced this issue Aug 19, 2024
Summary:
Fixes #46077

Changelog:
[Android] [Fixed] - Make Imagesource `open` for inheritance

Differential Revision: D61469357
@cortinico
Copy link
Contributor

We're going to ship 0.75.2 with a fix for this problem

blakef pushed a commit that referenced this issue Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Image Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue. Resolution: PR Submitted A pull request with a fix has been provided. Type: New Architecture Issues and PRs related to new architecture (Fabric/Turbo Modules)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants