Toggle showHeader flag in FacebookAdsApi constructor #286
Conversation
|
Hi @Sirach99! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Why the change is necessary?
The change is necessary because the headers in successful responses are currently undefined, which is not the expected behavior. Users expect to see headers in the response, as these are important for throttling API calls.
The logic behind the fix?
Toggling the showHeader flag in FacebookAdsApi constructor.
Pitfalls of the fix?
None to note.
fixes #282