Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get forked react-scripts changes to take effect immediately #7843

Closed
hosseinalipour opened this issue Oct 18, 2019 · 5 comments
Closed

Get forked react-scripts changes to take effect immediately #7843

hosseinalipour opened this issue Oct 18, 2019 · 5 comments

Comments

@hosseinalipour
Copy link

I have forked CRA, made some alternations to Webpack config and yarn link it to a project. after starting the project yarn start and then making some changes again to the configs, it doesn't take effect immediately. I have to stop the project and run yarn start again and again, I really need this for debugging purpose and I'm looking for it for a week now, supposedly there was a workaround that doesn't seem to match the current version of react-scripts. no any other information I could find in the docs or CONTRIBUTING.md.

any workarounds??

ver: [email protected]

@robertvansteen
Copy link
Contributor

We don't support forks of create-react-app, once you fork or eject and you make alternations you are kind of on your own. I suggest asking your question on a forum like stackoverflow.

@hosseinalipour
Copy link
Author

but at least I hoped contributors would help me as a contributor and future contributors, so I asked the question here. would you restart the server every time you make a change in the webpack configuration? that's a very time-consuming feedback loop!

@robertvansteen
Copy link
Contributor

That has not much to do with create-react-app and more with webpack. There is a feature request for it here: webpack/webpack-cli#15.

@hosseinalipour
Copy link
Author

the issue you point out is for Webpack v2, create-react-app uses Webpack v4 and it already supports watch mode and dev-servers. also, I found out there is dev server config in the CRA. but no explanation what so ever. so, is there any use for this file?

I mean when do you npm start to work on a new feature that needs Webpack change, do you restart it every time to see the change?

@robertvansteen
Copy link
Contributor

robertvansteen commented Oct 21, 2019

The request was made at the time version 2 was the most recent version, but the last comment stated they are planning to support it: webpack/webpack-cli#15 (comment).

I mean when do you npm start to work on a new feature that needs Webpack change, do you restart it every time to see the change?

If they are related to webpack, yes.

@lock lock bot locked and limited conversation to collaborators Oct 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants